[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v10 5/7] vtd: use a bit field for root_entry
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Tue, 1 Dec 2020 05:14:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrMHMsU9ngcsF76fZaDCMsSaDHV0e/vGyRm24Rw2OTk=; b=czPxKyh4H6u5PAOJ0iIzV2G2UTPd1hVrhKnQmxz46mzhh9BBtvkP/uX6tm5K10yz0pV/qSZk6FDiRELRNL5DvakQqc8PcYOTss2nR5iTmtgmm1b8kY51ZP5Q5iQAfPCwJiQD5pIWSAKgcyw73ibWWdfK/IBPaYDlYFTl/JZCvinuzjAUdsuGHDA7BrXFh+9fok5PBVXSWRt3C04XtPrG8N5Pf2O2MCMj8auIV69yw3lpCNp3oILIE8cMhu1B7bi8mopaU1NbOBXWWmFpvi5793tFT0GNaL9RkkFdGeikBXg8a+w3y+EmGA6Ip0FoU7NMrmFPw7D0++QCEfm1ZbkcvA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lETtPNVhmMDWh7FWaiDGq9kIGR0D0WVXL2g/rkD/Mh1/2GcPO86+Azi5DcbBiLXkhXizsnCh3XyUu9bQznkXN5kPG4dAXAXxN3Po38jE6mqs/Gpyy1Yr+d4P8Py1pR5GWhwX5ZkZ6OH97B0OKxd91JS5jS0rTNUIDJ8zW4mGgE8A/3kX0UmOjpW8iRdDq5jzoSDoha8GjeKMloKQBbSdci/jPp/QFp9WsXSECMVJz8Gj0gx8ujO82s8/CYC97m/tegB+7QZH/MQj3HjsDtwVcx/qHVXatzExe0hH+IPOgx25KVUNYMqjrSmwjigd7qwkKeFjjKS3WEkaHOf3N0TjMQ==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
- Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Dec 2020 05:14:19 +0000
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.5.1.3
- Ironport-sdr: XkMNV1+2CrEGkgM/4VsJNHGa/3sUKEybaEjGOngtXOJiIxB+AlBgd5uLCsNyHok1LYLpjYW0n9 +0MKC96LiaZw==
- Ironport-sdr: Y3smGJXVsL4fdnji/rGLWpdc9DGdRbZRQ2hchFG0Y9h2/jOpAeyNn5C3RKtX9xyJyAfwi1h+dL lFyDVQPDONKQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWv0COaWiEdvBtMUu0J5DvTo0K7angCUXAgABza4CAAUYrEA==
- Thread-topic: [PATCH v10 5/7] vtd: use a bit field for root_entry
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, November 30, 2020 5:46 PM
>
> On 30.11.2020 04:06, Tian, Kevin wrote:
> >> From: Paul Durrant <paul@xxxxxxx>
> >> Sent: Friday, November 20, 2020 9:25 PM
> >>
> >> From: Paul Durrant <pdurrant@xxxxxxxxxx>
> >>
> >> This makes the code a little easier to read and also makes it more
> consistent
> >> with iremap_entry.
> >>
> >> Also take the opportunity to tidy up the implementation of
> >> device_in_domain().
> >>
> >> Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> >
> > Reviewed-by: <kevin.tian@xxxxxxxxx>
>
> Besides this looking a little odd (can be easily fixed of course)
> I wonder whether both here and for patch 6 you had seen my requests
> for smallish changes, and whether you meant to override those, or
> whether your R-b will continue to apply with them made.
>
Let my R-b continue to apply. Those are small changes.
Thanks
Kevin
|
