[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/8] xen/arm: Remove support for Stage-1 translation on SMMUv3.
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Wed, 2 Dec 2020 13:13:03 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PxEz9Y3eMvGLMljvFhW1rS0tAmWJXxUok54w5uvoLmg=; b=EYrouWkzdPWkQAqK+/tUX6R7OsY7WYyTxVoYvdxnrLOWTyhO5YsEBSv755lEm/OLLLntlnvBb/wJTapTYqN7ZYofOMJTGNXp14qFVtnC1yxEsFmlrFxY2ntcM5TUKyN9sjPQ+9rbgY5vDMI//XUds+ntcLGp/nCpfHOX82q9jpyeq3AzR70KkXgezW3aMkD91eK+Jp8fKjPAQEkmVGKlItaO39qNa3dLidpvJowZHaEvmcKStcJ9dcYBUICmnpApjDSQO1NZzBFY1CTJ/qiBOjG6hOAeahwEDDChH39bDbpDI3NycLS+0mM5ryksco8g5iBUyl1q/2RLqYZQC1MV1A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mP03TGUZhSktOMwhQkHXrB7tnDsMoQDwodJKb7gn7uI/qDGHyVyfdzeeFTsSn8AiJGoB/fEfomvK+q4PUki5PoL2jd/VKrl3lbdKQoGHw4jKJEaZnu0qbZT0CXGOCibp4rFDvMrGjLegCd2qaTzpIB3H20O9WaHCks1E7f1YB9S+h78WB8n7paDU5sRx05pYeZU/KpEaQV8M7BEMNgcheOYT/MPbV9JoXsFIpACPWvPj16VD///CvQ+v8fibtZMfIyIFREegA7mRLfGXq/TUymlR3SDniKxOxR0jvBPZv7PkyERT+MWoom3JuvkzxosN1K+E/ccWbUd6t8/NshUmnQ==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 02 Dec 2020 13:13:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWxBX8ar/P6AWgZUeUeAQIZFy5kKnjAtQAgADOu4A=
- Thread-topic: [PATCH v2 6/8] xen/arm: Remove support for Stage-1 translation on SMMUv3.
Hello Stefano,
> On 2 Dec 2020, at 12:53 am, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> On Thu, 26 Nov 2020, Rahul Singh wrote:
>> Linux SMMUv3 driver supports both Stage-1 and Stage-2 translations.
>> As of now only Stage-2 translation support has been tested.
>>
>> Once Stage-1 translation support is tested this patch can be added.
>>
>> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx>
>
> [...]
>
>
>> @@ -1871,19 +1476,9 @@ static int arm_smmu_domain_finalise(struct
>> iommu_domain *domain,
>> }
>>
>> /* Restrict the stage to what we can actually support */
>> - if (!(smmu->features & ARM_SMMU_FEAT_TRANS_S1))
>> - smmu_domain->stage = ARM_SMMU_DOMAIN_S2;
>> - if (!(smmu->features & ARM_SMMU_FEAT_TRANS_S2))
>> - smmu_domain->stage = ARM_SMMU_DOMAIN_S1;
>> + smmu_domain->stage = ARM_SMMU_DOMAIN_S2;
>
> It would be good to add an helpful error message if
> ARM_SMMU_FEAT_TRANS_S2 is missing.
>
Ack. I will add error message.
Regards,
Rahul
>
>> switch (smmu_domain->stage) {
>> - case ARM_SMMU_DOMAIN_S1:
>> - ias = (smmu->features & ARM_SMMU_FEAT_VAX) ? 52 : 48;
>> - ias = min_t(unsigned long, ias, VA_BITS);
>> - oas = smmu->ias;
>> - fmt = ARM_64_LPAE_S1;
>> - finalise_stage_fn = arm_smmu_domain_finalise_s1;
>> - break;
>> case ARM_SMMU_DOMAIN_NESTED:
>> case ARM_SMMU_DOMAIN_S2:
>> ias = smmu->ias;
|