Re: [PATCH v2] tools/libs/ctrl: fix dumping of ballooned guest

[Wei Liu <wl@xxxxxxx>]

On Wed, Nov 11, 2020 at 11:01:43AM +0100, Juergen Gross wrote:
> A guest with memory < maxmem often can't be dumped via xl dump-core
> without an error message today:
> 
> xc: info: exceeded nr_pages (262144) losing pages
> 
> In case the last page of the guest isn't allocated the loop in
> xc_domain_dumpcore_via_callback() will always spit out this message,
> as the number of already dumped pages is tested before the next page
> is checked to be valid.
> 
> The guest's p2m_size might be lower than expected, so this should be
> tested in order to avoid reading past the end of it.
> 
> The guest might use high bits in p2m entries to flag special cases like
> foreign mappings. Entries with an MFN larger than the highest MFN of
> the host should be skipped.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked + applied.