RE: [PATCH v5 18/23] libxlu: introduce xlu_pci_parse_spec_string()

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu <wl@xxxxxxx>
> Sent: 04 December 2020 11:34
> To: Paul Durrant <paul@xxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Paul Durrant <pdurrant@xxxxxxxxxx>; Ian 
> Jackson
> <iwj@xxxxxxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Anthony PERARD 
> <anthony.perard@xxxxxxxxxx>
> Subject: Re: [PATCH v5 18/23] libxlu: introduce xlu_pci_parse_spec_string()
> 
> On Thu, Dec 03, 2020 at 02:25:29PM +0000, Paul Durrant wrote:
> > From: Paul Durrant <pdurrant@xxxxxxxxxx>
> >
> > This patch largely re-writes the code to parse a PCI_SPEC_STRING and enters
> > it via the newly introduced function. The new parser also deals with 'bdf'
> > and 'vslot' as non-positional paramaters, as per the documentation in
> > xl-pci-configuration(5).
> >
> > The existing xlu_pci_parse_bdf() function remains, but now strictly parses
> > BDF values. Some existing callers of xlu_pci_parse_bdf() are
> > modified to call xlu_pci_parse_spec_string() as per the documentation in 
> > xl(1).
> >
> > NOTE: Usage text in xl_cmdtable.c and error messages are also modified
> >       appropriately.
> >
> > Fixes: d25cc3ec93eb ("libxl: workaround gcc 10.2 maybe-uninitialized 
> > warning")
> 
> I don't think d25cc3ec93eb is buggy, so this tag is not needed.

It is. If you supply the '*' for all funcs then vfunc_mask is set but func is 
not... so you then hit the assertion at the end of
xlu_pci_parse_bdf().

> 
> > Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> 
> Acked-by: Wei Liu <wl@xxxxxxx>

Thanks,

  Paul