[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 7/8] lib: move bsearch code


  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Wed, 9 Dec 2020 14:27:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Agrz0qaGZgpl61pf9qGCx/YT91JtFl0hwm5ZWOGy5uQ=; b=kQOChzO8uTuUxMvCVIHyW/cKbtw82/2jdQiHv1pTxV1lS8+3VEkexce3rM5TZtp0oE40dHlbI6jjT7ywQWmGwud+jvtvGsutciIcnmjs+NFJcKGKoY65J7AWNYG70q2Mn/09/USHCPPGWALL5UeHoGs7kwu+SSd6nSmJQU4Qz2I0MGDe0laxPYdvGbWVTrswEMmeQUDWVUiGfJ3GFM4mpXPGcWhn/0P8LA0NMi83mlIGGikVXYSbL759AQ3JHEdM9AU7sR2TcJU7mVYfHdUxRv+NF+aIh5sUZkKkj2Yx/5FiI18XCoRvHfg1+Qn4CfYqNfBycn0CwnOM7QsoinnmUg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mKLKwe1G257P0qqicc7GmXnW+iQBajrtizG9m1J49Jtxk6VoZZv+tXpesdWHrPibphkH/mF1jCwpUX8lpdhGIwy8gPhFyVAVSm5inrWxqFrp6RfZEQDjJqnHfiwGFyX4Hsvl/58su1OifroCjgZf1GcE4Y9QErhLTNUMLKyZmINeX6+6OHHouSOIl67KHYPXeBAf5yyzzp8o5kfvo4KXmUbz5JFZTwYgpkUbSOTMThfjEw2J6cGkH8ZHwfZAQNK0syrNL4ckKoqFpStgME3vBEaTS1Ysizxeaswmf7zIRlZLKLX75NMO4sNUK8GshTSCaWeHUzZaicmFrQgcRhKcBQ==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Wed, 09 Dec 2020 14:28:05 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWqSYUW6jKcf9JAUabryyJK6872KnOWaMAgAERSYCABxiQgIAAHyEAgAEQxgCAFABlAIADGMmAgABP5wA=
  • Thread-topic: [PATCH v2 7/8] lib: move bsearch code

Hi Jan,

> On 9 Dec 2020, at 09:41, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Jan,
> 
> On 07/12/2020 10:23, Jan Beulich wrote:
>> On 24.11.2020 17:57, Julien Grall wrote:
>>> On 24/11/2020 00:40, Andrew Cooper wrote:
>>>> On a totally separate point,  I wonder if we'd be better off compiling
>>>> with -fgnu89-inline because I can't see any case we're we'd want the C99
>>>> inline semantics anywhere in Xen.
>>> 
>>> This was one of my point above. It feels that if we want to use the
>>> behavior in Xen, then it should be everywhere rather than just this helper.
>> I'll be committing the series up to patch 6 in a minute. It remains
>> unclear to me whether your responses on this sub-thread are meant
>> to be an objection, or just a comment. Andrew gave his R-b despite
>> this separate consideration, and I now also have an ack from Wei
>> for the entire series. Please clarify.
> 
> It still feels strange to apply to one function and not the others... But I 
> don't have a strong objection against the idea of using C99 inlines in Xen.
> 
> IOW, I will neither Ack nor NAck this patch.

I think as Julien here: why doing this inline thing for this function and not 
the others
provided by the library ?
Could you explain the reasons for this or the use cases you expect ?

I see 2 usage of bsearch in arm code and I do not get why you are doing this for
bsearch and not for the other functions.

Regards
Bertrand

> 
>> Or actually I only thought I could commit a fair initial part of
>> the series - I'm still lacking Arm-side acks for patches 2 and 3
>> here.
> 
> If you remember, I have asked if Anthony could review the build system 
> because he worked on it recently.
> 
> Unfortunately, I haven't seen any answer so far... I have pinged him on IRC.
> 
> Cheers,
> 
> -- 
> Julien Grall
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.