[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON
* marcandre.lureau@xxxxxxxxxx (marcandre.lureau@xxxxxxxxxx) wrote: > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > This allows to get rid of a check for older GCC version (which was a bit > bogus too since it was falling back on c++ version..) > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> Yes I think that's OK; this is an imported file, but we've already mangled it into QEMU's style and added includes etc. Reviewed-by: Dr. David Alan Gilbert <dgilbert@xxxxxxxxxx> > --- > tools/virtiofsd/fuse_common.h | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/tools/virtiofsd/fuse_common.h b/tools/virtiofsd/fuse_common.h > index 5aee5193eb..a2484060b6 100644 > --- a/tools/virtiofsd/fuse_common.h > +++ b/tools/virtiofsd/fuse_common.h > @@ -809,15 +809,6 @@ void fuse_remove_signal_handlers(struct fuse_session > *se); > * > * On 32bit systems please add -D_FILE_OFFSET_BITS=64 to your compile flags! > */ > - > -#if defined(__GNUC__) && \ > - (__GNUC__ > 4 || __GNUC__ == 4 && __GNUC_MINOR__ >= 6) && \ > - !defined __cplusplus > -_Static_assert(sizeof(off_t) == 8, "fuse: off_t must be 64bit"); > -#else > -struct _fuse_off_t_must_be_64bit_dummy_struct { > - unsigned _fuse_off_t_must_be_64bit:((sizeof(off_t) == 8) ? 1 : -1); > -}; > -#endif > +QEMU_BUILD_BUG_ON(sizeof(off_t) != 8); > > #endif /* FUSE_COMMON_H_ */ > -- > 2.29.0 > -- Dr. David Alan Gilbert / dgilbert@xxxxxxxxxx / Manchester, UK
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |