Re: [PATCH] xen: Rework WARN_ON() to return whether a warning was triggered

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 15/12/2020 11:31, Jürgen Groß wrote:
> On 15.12.20 12:26, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > So far, our implementation of WARN_ON() cannot be used in the following
> > situation:
> >
> > if ( WARN_ON() )
> >      ...
> >
> > This is because the WARN_ON() doesn't return whether a warning. Such
> ... warning has been triggered.
I will add it.

> > construction can be handy to have if you have to print more information
> > and now the stack track.
> Sorry, I'm not able to parse that sentence.
Urgh :/. How about the following commit message:

"So far, our implementation of WARN_ON() cannot be used in the following 
situation:
if ( WARN_ON() )
  ...

This is because WARN_ON() doesn't return whether a warning has been 
triggered. Such construciton can be handy if you want to print more 
information and also dump the stack trace.
Therefore, rework the WARN_ON() implementation to return whether a 
warning was triggered. The idea was borrowed from Linux".
Cheers,

--
Julien Grall