Re: [PATCH] lib: drop debug_build()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 21.12.2020 19:07, Andrew Cooper wrote:
> On 21/12/2020 16:50, Jan Beulich wrote:
>> Its expansion shouldn't be tied to NDEBUG - down the road we may want to
>> allow enabling assertions independently of CONFIG_DEBUG.
> 
> I'm not sure I agree that we'll ever want to do this, but...

Didn't you once say XenServer keeps (or kept) assertions enabled
even in release builds? In any event, having such an option may
e.g. help diagnose issues from mis-optimization (no matter
whether because of mis-compilation or because of subtly broken
sources).

>>  Replace the few uses by IS_ENABLED(CONFIG_DEBUG).
> 
> ... we should be aligning on CONFIG_DEBUG.
> 
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> I wonder whether we shouldn't further abstract this into, say, a
>> xen_build_info() helper, seeing that all use sites want "debug=[yn]".
>> This could then also include gcov_string right away.
> 
> I think that would be a nicer way of doing it.  It should probably also
> have some trace of CONFIG_UBSAN in the resulting string.

Okay, will do.

Jan