[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/CPUID: suppress IOMMU related hypervisor leaf data


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 28 Dec 2020 11:54:00 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LpM7rJsbNXNZkIwxZw9lTa3osUmNvyJ5S5GGOfBGHKI=; b=Tz643cahIC0OHowudSHfPmwJWT+6hyVK3GFkqmWHrjlN5pae8/ntbFbB8X9M6Ld/OdHs8RhMHaUp6OicIkRVJLq07KDTq+3cGAcUgji/PEwsdQ00RRpdLAvR/iv9sl/mxKoCNsMXj0axQktPZYztfvOKhyvuRPzM1AmUg2Nf5+VUsbZUXj4meZ3saJVJxLGgHUIp2bDT5+HIpZUl+wI6LTYQFyL0dTIqtYzEg4xvZHjQ4K1VkHy42F4AwQQg/6hXnq+Sq1Ao1O1r2iPCrWRNxdIHHBWO9HQxUmxzmOUJODnmf5YMeKgWvZRaPlQhI5ol+3LD/5QNezhHkmpc9kvH6Q==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gvo0CMeCINwcxrrdSAQKWx7A4tkR5U+e7W7WJ6uF+aH5CR4cEPKbPyQbvUBKi/jrQMMyuO2bkuwTdKUPBwq9ZAxG4UBspMKtkEw8ww0PT4RsthqtWtf5VFlm0X4SaIEF1QkR49/tTRUDD4XMUW49iLPTHt5cX9xtkMyv7+K/wumy/ylREDaYngFKGYYMwPTe4u9IhDpe0CWw9GCQpIauzltf4mhJwao5PsWTRSwf8QitrEcVRqDXkxSNl1I67Z29K1QVWDcVQ/huMcZhb2W3lEsKbHureSFZRdq/jvWVvERUNW7ewOyxFTyXtcaPVszftv6+YEZG09nw56oWtpRx7Q==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 28 Dec 2020 10:54:35 +0000
  • Ironport-sdr: j0SnspgokMNyiUXbVAkvyighxuOgX38Jdnyaf65/CzS4t3JkzduUJ2GVkJdqn8IoAex6m1Fv+N W1yOZ9EbauAmScnHGmhLG22bLJ8rdge4qEBhsTaQ3eOGJ9BPXwFNivsBzAXXqMIgaQV3IVCGIh J58rwmwnP7aquJeVp6C9uL/6SJWp2wQsNfp+3sYMEtWlDyskuMWug9PA2sPfqDqZUvIJKsnvap uDFsIjLZlqA+rQ4yzt30dAnIqXeeNE9w4sXcZVDiHaTyeB+JmOeF9RYNpsC4xgndxgnmUdFWhp FfE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Nov 09, 2020 at 11:54:09AM +0100, Jan Beulich wrote:
> Now that the IOMMU for guests can't be enabled "on demand" anymore,
> there's also no reason to expose the related CPUID bit "just in case".
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

I'm not sure this is helpful from a guest PoV.

How does the guest know whether it has pass through devices, and thus
whether it needs to check if this flag is present or not in order to
safely pass foreign mapped pages (or grants) to the underlying devices?

Ie: prior to this change I would just check whether the flag is
present in CPUID to know whether FreeBSD needs to use a bounce buffer
in blkback and netback when running as a domU. If this is now
conditionally set only when the IOMMU is enabled for the guest I
also need to figure a way to know whether the domU has any passed
through device or not, which doesn't seem trivial.

Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.