[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/24] Implement gnttab on NetBSD
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 29 Dec 2020 12:16:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HUu4gJqmQhIfsr00LsR7GNefx0PASAC/mDprSMGGMM4=; b=VfVkFKrVwBNridumPGE4aY/R6XazcwwKviSvO35/KzAWNzSrFr4IIsKUvkXD58kM3HS5ZMs4SbOpGff3iWu2LibHWlksOZHGTL+4BUE75aOKVAEvrMESKD7dP8H11NJ/QbCG+S4PsTTxmIyIfgQPnL/o7LXIKDmreCfrGZuw+J56SbSmCxSh3RmUwb9mJPNfw0p6+zFnxUCR5+7P+0/27RgG2TMtYmlD5AjKaNAkedOSASr7BzuewCiibJ95n20XfvW4cbq8sPWur1G9PEvgx9OmeOYkI5AwEDC6IDraiOKPWQoA5sV3ew72b7pq86OKmlzSf+XcnCc23eatwkDGGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alWmzfk7b4711+hZk2vsCUtVBW7sPZN1iiqIBOpoJBeqnlHa8OdUtf22SbAKD3SJQq7toeOxdtn2qfW5L1n3n7PikOsbBArSKUaq80H2hfuPR+GxAIeanL9xHbT9dhv2GbtMgMuB5xD8qntvH5fYJCWmXfMQyXifutJwBH1IwBDQ2VYlTwaYhILUbnd/zcZTeLrdnf9+4SjncTbvD2oZdlNIB0grhBxM/hDxsNpfar9Rn5tYxvM3nvi7uTBk7+wf/QVeHOzzIDWynLw4CjgvfUhSd9dPXbXDeW/9VGAUeRpBiTU1LuNUDBDi7WXfspaKuo3QsqB1fjZxyWoQOHK8Fg==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 29 Dec 2020 11:16:29 +0000
- Ironport-sdr: Z+RkW+IrBADWnOu3hdcYOuRXbU1OBQDW8abGrfjWvqQn8rUqDbTMjMkhl8uKUYA0rB6g1TTbHL +a+iif6quwBkJOicfWR6/6AXWdzvr1vdoAbNCpAThQwE/VT+ilcc7uAV7R/oyuQeFNQa6Ac7r7 eYgBqMIlcES3Ukvg5BUQocoC79yiWtCM5XwtGu/kggxt5ubaxmNyvd4YrC7Nk/BtpCLCP0mEgr OQ4aZCE+/R8M4IH1r2BzxwD3ZdrkGfecNH4OymZTwOEKDfgqRvl7EWiHM5utISyX3mCyHEj9JF LKk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Might need some kind of log message, and will also required your
Signed-off-by (or from the original author of the patch).
On Mon, Dec 14, 2020 at 05:36:11PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/gnttab/Makefile | 2 +-
> tools/libs/gnttab/netbsd.c | 267 +++++++++++++++++++++++++++++++++++++
> 2 files changed, 268 insertions(+), 1 deletion(-)
> create mode 100644 tools/libs/gnttab/netbsd.c
>
> diff --git a/tools/libs/gnttab/Makefile b/tools/libs/gnttab/Makefile
> index d86c49d243..ae390ce60f 100644
> --- a/tools/libs/gnttab/Makefile
> +++ b/tools/libs/gnttab/Makefile
> @@ -10,7 +10,7 @@ SRCS-GNTSHR += gntshr_core.c
> SRCS-$(CONFIG_Linux) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) linux.c
> SRCS-$(CONFIG_MiniOS) += $(SRCS-GNTTAB) gntshr_unimp.c minios.c
> SRCS-$(CONFIG_FreeBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) freebsd.c
> +SRCS-$(CONFIG_NetBSD) += $(SRCS-GNTTAB) $(SRCS-GNTSHR) netbsd.c
> SRCS-$(CONFIG_SunOS) += gnttab_unimp.c gntshr_unimp.c
> -SRCS-$(CONFIG_NetBSD) += gnttab_unimp.c gntshr_unimp.c
>
> include $(XEN_ROOT)/tools/libs/libs.mk
> diff --git a/tools/libs/gnttab/netbsd.c b/tools/libs/gnttab/netbsd.c
> new file mode 100644
> index 0000000000..2df7058cd7
> --- /dev/null
> +++ b/tools/libs/gnttab/netbsd.c
I think this is mostly (if not equal) to the FreeBSD version, in which
case we could rename freebsd.c to plain bsd.c and use it for
both FreeBSD and NetBSD?
Thanks, Roger.
|
