[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/24] Make libs/evtchn build on NetBSD
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 29 Dec 2020 12:52:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FMO+j9fnXhMTz0TphLYNM7Lq3Z2h/FnovwmDaT5f9T0=; b=BbzbMKdKBCSKkS4myCieCus/i9vnK8BN0nkztjaAV3d87lPGSLx5kt1IGDucTBG5M/cYTGKOIOUBB/03dwzSvJbFv/dHxujdiot+TuXH+Zk3z2PuYkNstRimnAFVValKhWWfi5KaX5wa3Uuqm+ypMaakrkJO+jW9lHDCppaooVW1P5cYz+l1IfDz9QUYk3pAcnCnXagHt1ioDrux1nP8721f8wviMOMEJpVqNt7sNxliRFYbNIh0wXxJGD5au3gwUUyi9j0TYNh+SAlT4J3XufP++xWBRxxcbZZZ0iQdr2V+ryZRhuTOzyTSJh1WCdwgGEwdkIsDw//rSvVCoTIZJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k/8h129szrsmbb4CoSgjJ1EdQ77/SdeXPTWMWxNUneXDf0OGZHKde2mfZbv/vScp50pUr/NZmKp+XAqK03EM2cEf8dxCag1+Ip/aJy410ELwQEMmRkfp2SP1mu4nogesYKHOxezhQ8LlnQlbG/kNzUz7XlKUhjR4TjjLIwLGe38nAGRfoMd0TLyv2R3Fsi+ILkOhD0/Qx+Babfkvh3ViWgIC+WTUzjhjz5F9bQD3SD1dHrWEjPSJT6WvECzsy/6Wq88exFmuWFnlRVWMZVtjxfhfHaz7ZUxFmWR9zGE6PkqLALMCoYBSE72vbbAthaKAP2cUXi2Tnl8auQQjs2I1cw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 29 Dec 2020 11:52:56 +0000
- Ironport-sdr: x4XN6Jd1ePoZpnXy0Aa7J28kPzIeULdzQEqrrwkpSmGuVZb4clME6ABAS/bInvhOh+l9LMCNb7 2F1dGZvVXafScPTJReu0hzPdk1POtKOz53x6Gqq4TIvNKeMoDFS8Qn4BFqj0SrbY0UcaROmQgW hjC7Qxzukn0Cqtddz1XX7S6EV6QSK5yRGyiyRoEo8wRaJ7RsLCBhUtVBkWxFICJfD9Nh0/aov1 oaNIzeJbTL5/vlBzsVREQ1oSbU96WKRJsALyljuw70FPwEEHoE0IeyWliDqbbOx2KQlPYsMEni /7k=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Dec 14, 2020 at 05:36:09PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/evtchn/netbsd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c
> index 8b8545d2f9..6d4ce28011 100644
> --- a/tools/libs/evtchn/netbsd.c
> +++ b/tools/libs/evtchn/netbsd.c
> @@ -25,10 +25,10 @@
>
> #include <sys/ioctl.h>
>
> -#include <xen/sys/evtchn.h>
> -
> #include "private.h"
>
> +#include <xen/xenio3.h>
> +
> #define EVTCHN_DEV_NAME "/dev/xenevt"
>
> int osdep_evtchn_open(xenevtchn_handle *xce)
> @@ -131,7 +131,7 @@ xenevtchn_port_or_error_t
> xenevtchn_pending(xenevtchn_handle *xce)
> int fd = xce->fd;
> evtchn_port_t port;
>
> - if ( read_exact(fd, (char *)&port, sizeof(port)) == -1 )
> + if ( read(fd, (char *)&port, sizeof(port)) == -1 )
> return -1;
>
> return port;
> @@ -140,7 +140,7 @@ xenevtchn_port_or_error_t
> xenevtchn_pending(xenevtchn_handle *xce)
> int xenevtchn_unmask(xenevtchn_handle *xce, evtchn_port_t port)
> {
> int fd = xce->fd;
> - return write_exact(fd, (char *)&port, sizeof(port));
> + return write(fd, (char *)&port, sizeof(port));
I'm afraid we will need some context as to why {read/write}_exact
doesn't work here.
Thanks, Roger.
|
