[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD)
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 29 Dec 2020 15:02:15 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mm6Cdv61E5EFUzA1Vtu6CqolBNW57o6oC1DXEVZJgN8=; b=QbZVti40msp9oHGYHNOfD8VZlDWeqmmL8O3pbH3KAqN9mmfkN5fYN2ErNKoRMidXXYMCTmUlo/Yot3jxYGQzfCtIxHqm+2Ox8bwQYpwIBqIIsYdxc6Sgqc0KHqQKJUJEMEKgVLjZqIx54fErBxbPVrw6FS+We6H5EhSj7tARJxEK3zEtH/x6/DFxdJi5I1jsDwBi7XD0MaxyZUbndPZ0b8XKhMA61XR3WeA8rek7o4k/koVcHpzVQTOpUm3HUAG5xMi5GL4ua5guFp6GmRoisYg+irkjVQ9/ENVK3DTwY0+k083P+0wqlqSVPsjxBds9QkShlX5IIzsKUaQ9nRC1vw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWycmHXWvdBEgQaFupU9yGu8yepyugGMSe8lsFSWq4fvDNeo1igMbvynuNz1p2lwKbKMsASskM1ET7PCWHwVwVmIf7DUVu9BVDeyjqnFYNAQ0HXrlpjb4u1gdSEikO+lBulSiqrf+ON/6kxHz1uD2AZ25m9dNtt94YTyUd3RAWn1zfSwoPJdKuUlQoWCy8b+PsBzZDGD8YOk4qe5FvRWlNxACvh33mVZ7re2/WsaCtYvi6ULJ4h3U5CvSvDyEmlAJ3U9kRFZUH6bepk175pwiz11dF7lyEWDh/pXsH+RDY+cEx1icSWh12pBGZTpkYjDtLFWMu/Iw6M9bGMGg+HDdw==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 29 Dec 2020 14:02:48 +0000
- Ironport-sdr: NI82ovU2MoKJVF7geU070lxpwIQI6wsnr0dFw0ov40iJHI6SgAxlCxQp2q/e0h0e11eQI8T8lu QnFltl1UrhzIod2ftbrYGKIrfk0svWi1BAhCUGdp99kp66fiFqF+AtwjFZiDnKh0ef6zfRbjn+ P04IRDYcL0wdq3izua5Z+Yig6Nj7dXQ+LmPBqd3Jeib5TTtp0Z6sJxY9Bk9rXc+sef87qabt5B V1//9dTt9rdXzpPam68tAoZ0SXJbDsQksjJD5a77QXgcAnJ8eU+Joo+SCyFnp+4yrbdTEJG0WY hEQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Dec 14, 2020 at 05:36:12PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/light/libxl_create.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index 321a13e519..44691010bc 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -496,7 +496,7 @@ int libxl__domain_build(libxl__gc *gc,
> vments[2] = "image/ostype";
> vments[3] = "hvm";
> vments[4] = "start_time";
> - vments[5] = GCSPRINTF("%lu.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
> + vments[5] = GCSPRINTF("%jd.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
You don't cast tv_sec to intmax_t here...
>
> localents = libxl__calloc(gc, 13, sizeof(char *));
> i = 0;
> @@ -535,7 +535,7 @@ int libxl__domain_build(libxl__gc *gc,
> vments[i++] = "image/kernel";
> vments[i++] = (char *) state->pv_kernel.path;
> vments[i++] = "start_time";
> - vments[i++] = GCSPRINTF("%lu.%02d",
> start_time.tv_sec,(int)start_time.tv_usec/10000);
> + vments[i++] = GCSPRINTF("%jd.%02d",
> (intmax_t)start_time.tv_sec,(int)start_time.tv_usec/10000);
... yet you do it here. I think the first occurrence is missing the
cast?
Thanks, Roger.
|
