[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/24] Make libs/light build on NetBSD
- To: Manuel Bouyer <bouyer@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 29 Dec 2020 15:28:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3SwvUQp001dK63uoLpS9nHeRnhOPlo3FkXiMtSA5P98=; b=PIGhmnfXxPGWYZbqcoNBotmiFDxdambNJCIiWaMrFdOhjp0gNK/55/KsUJY/cdYF2UgnHv39eP4ANgMSY+S2rpb/Kf/43CsEQmvoi6gd0fI19V5YGBxHsbMzCVBK1MaRViz5VRsjQpZxwizgdBZYkWrl4m+QumWJDpsPVV8nQfOEUqfmOe/sej/NYLSxSsBdQq4GbiIsBbQWKwmCS4fC0eQp/Pm+08EFlP+IJe167peG+HBBUt0jazf05+4VLn/lUInFlLZ1GFe912VXk1W4O06c4EWxGdl7WAT550OqKogUKjLZd+niTqtQEZchajl5RKYqRpQowFiSc8GjZKwa9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KXjaXBnK/4iJxYF1IsGTy02VvNFOHt3vtxOEmEWXKzzSgTOTJQ1AvN7Wc7LiQ2D3JMH9mry4kvQ1pHP2hhbFLM6qCUSSFXMuUm3kpEcbBGgTxG0o5jR21Cd7lV7+r0IUl4Pn7CY0nMsK+3pypx9q/BE7Znz4FpNdkiDVsMXJKM7b4ZQKbjdP8WDXBtFnS6k/sL23A/rQsS59PpXg99SwhVokFKPk2q49OKxN4BsWxT8XazOrTF5kqfpN10xIA/3F2JG+lVFCjCgWcTT/zvZcOOwT8Wo26ExmGqM00hmyqdqJFPMiNPi4USGmjMq1ZuFXeM8bj67cqfwiU0p0nfFpmQ==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 29 Dec 2020 14:28:19 +0000
- Ironport-sdr: 3/Y7gZN6tR6QgyMRjAQTA8kjB1n5KGE0mcrVWOQMR2i7BLD+kr5tgR+pRugEexH6HC9qPvJN8Z 9Ux/Udyjx9yQP2n9VjQ2cC1wF1ZbOwi1JsY0U3KVf1r6dUoDBGZ9+MUbmeeNBaJqvO+CJVhy4y i8dEm55tD31mnjFCZ5rXsP9ohw2AQGGBMpHH9rt7ixtoxpgJw4GuG3rwInB07qFmkTRGYK9DfF l5vHTeUUGUKuJHFjdEyG3hbwZGJ+SRrW16Xeaq+JoTaktVwCesg89Z6A3PRX2KX5NglIPm2ncm 3bc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
There's already a patch with the same subject in the series. I would
recommend to be a bit more specific with the fixes, specally if
there's no log message. This for example would better be:
tools/libxl: fix uuid build on NetBSD
On Mon, Dec 14, 2020 at 05:36:16PM +0100, Manuel Bouyer wrote:
> ---
> tools/libs/light/libxl_uuid.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libs/light/libxl_uuid.c b/tools/libs/light/libxl_uuid.c
> index dadb79bad8..a8ee5f253e 100644
> --- a/tools/libs/light/libxl_uuid.c
> +++ b/tools/libs/light/libxl_uuid.c
> @@ -82,7 +82,7 @@ void libxl_uuid_generate(libxl_uuid *uuid)
> uuid_enc_be(uuid->uuid, &nat_uuid);
> }
>
> -#ifdef __FreeBSD__
> +#if defined(__FreeBSD__) || defined(__NetBSD__)
> int libxl_uuid_from_string(libxl_uuid *uuid, const char *in)
> {
> uint32_t status;
> @@ -120,7 +120,7 @@ void libxl_uuid_clear(libxl_uuid *uuid)
> memset(&uuid->uuid, 0, sizeof(uuid->uuid));
> }
>
> -#ifdef __FreeBSD__
> +#if defined(__FreeBSD__) || defined(__NetBSD__)
There's no need to add NetBSD here, just remove the #ifdef altogether
and the content of the #else branch, since this section is already
only for FreeBSD and NetBSD (the #else variant was only used by
NetBSD, see the #elif defined(__FreeBSD__) || defined(__NetBSD__) up
on the file).
Thanks, Roger.
|
