[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hpet: Fix return value of hpet_setup()
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 31 Dec 2020 09:55:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zjLV/lVtDp/RXbWyIND1cVbX3sYXc0cfPL24c74fCjc=; b=djSq4l6H43RK6kC9jHnOJ0ey5CKvna/N2jakC4PHLVYURv66ZTt5RBuneFFFtKXqCSssyBAdaM3/qIUYED3/4EooMrrfIXIsNad+eft9v5wmONxIqQ6QpCEH4otyRLc9HioMB6XCUFpLRmVMwLyFQMam5aCFBOnMTyJZ3DKSr/Ef3JQdVoWrmF442VsqLmwC7Ia/7FZYxbo/v34Zx4yxHxfF5RyoC/rA2FJNUJAmDyppKV4V49QGkUvqM60d6uxLkd+yZJXjAuAUrMoV9VV6+dvyD5h/oqZN0Gd1ZZehxfEtw4SdoDpKsszomyoBR1xifXwR7sE2cmjV/vIBFHEdyg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dl5f38yyLg8T6Wt8JyFM4LRQrl/RXVL9nqs5Ky9S0VIOiUC1WsaKQ1+FbzGqzJK1cL5mRHfGnWkzWSTidB3Eqg8g1Zviae1FXPJF2bgJg7pH9mxhATIMKVvpOS1mYcKpG3Lg3AP4wrxWHfvnf4u8oObGaz8A2SbamKc+yUwDzic2rt9/Ong6JTVA2hfFcVXCojVwdEpJED5CaS/aQOf2hlX1BHR4piI/FY6oE9/wALBbmX1cZkpMktM10kaI/Cs/clUeC3Eg1vKHuBhiEFc4Vk4G30fbDgj/9jjIbLB9rF+bngOwtFCJSMKQYRjPACsmap+JMkSc9up5ovTYNaxNkg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 31 Dec 2020 08:56:01 +0000
- Ironport-sdr: qowIPzAUlAFrcXSxV8cDoFcU7KZNnxap9yJx41ler5EQL9tf5Lk7Pll7bRKYFCrYCakQ9alf9X d5D7753YIDoTQbVCPjPxlyJlKhMEFifg5rFaK0MjWzBAH1bxIMGzcP0lGXV4WB9Dj5s6+20PiZ ukNPc3pmJZI3q3vyXoWL0jS4epAIksOi0jXaOmbapSeRSW5d0k6GELlhw77PiIGO1oEIJB7QDo +9Aq7nMXroPtc8Ha7y/VrYMc2QF/9VU7a7fSQAUSQzoSDw8sWwyAMYo1zBlIaTSWWW3SoooICx +IM=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Dec 30, 2020 at 04:02:08PM +0000, Andrew Cooper wrote:
> hpet_setup() is idempotent if the rate has already been calculated, and
> returns the cached value. However, this only works correctly when the return
> statements are identical.
>
> Use a sensibly named local variable, rather than a dead one with a bad name.
>
> Fixes: a60bb68219 ("x86/time: reduce rounding errors in calculations")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
