[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/p2m: Fix paging_gva_to_gfn() for nested virt
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 4 Jan 2021 14:17:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6GkzFCQq5aY2BGrWLxUmCMej3tD4FCVV4/AxIhcPRWg=; b=Qjd3lrEDZdAUcCDVtQhB+RXYXYNcjzDnl85wnY1n9Sshqi6ZySJvKUarIzCRvHTSqckGOY0fcMgfW1NHD0XVBdyRP99p6k5kDIRfNhuFzrx8KHkp9so/BhuEjv8h1M5+NEzQzGY8eDKx8to7VN9Ih6bfOuWrr35oNywpoXFH8TudeRY2k3fL9lxurfyZYOZUq96N3abk69H47JjKDuKVNew1coq1hG6KBl7bIKcI+Da31don7xYu0YjAlRmLqSSSpV25NKpECLRTxGZU3VMTSHTkeI6n5ggeOqs/GL831zmaUFBjithBmYtv191fuadKhtQJDs+P/zY51Jq1tuoDGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBQ1U2mjHqbztTqfDxtoBlC9WqIvAKwW/wKQ7mbBEOsWBXJ4n/EpaDYPR6K0mb9YnzllLkdCqRhOm/uhL1NDejwUiqkkTWqQldBTYvnGi1yhQ4WGuIgBacHxNEGEu2MTiVz+DsbsztTM3fXJESoQQUxsocINB8chSy8Udq+alitwWO2oPV1aC5CX/1FeDZua0LYbTIelDVyIb4mc0MaVMywZ9oL4jlTJUi+Reen18D0ahoUHLEvIIGUIOzxNXouKxqvILhrD6uqWwQiNcvo3U+nerOHjdqCrqWZRk3zHfp0rl8t4D3C3Qb3dEO0eH0QUpf5jp6ZcNB70IEf9TsIV8w==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Delivery-date: Mon, 04 Jan 2021 13:18:12 +0000
- Ironport-sdr: u72Bg9S6wbnZKlkH2x1LQPMDGD1R2c0PPpv0yo0LJogJ50gPfrdnQqJ/WEomWURIu3xHDMgNO3 l9/bhptjka5e5oGTf0FST6nVRCfR2kKNjv5j2QcSKXJGqiCO0IFyu0WVrX3AR1iLos678V5zM9 20PUe8w4WMtpSUXXzft1qzwDgf17aJ08m964F6gTDkNqthMUgUJqq+jigSpeDLgFiaUi8t2O5Z 5sdIlKva6M1KS/T1ZWKuhPvyNHTe94SoFl6COZkYOes/i25PQJY83sfdsVO66+v9jgpi+n+k44 3k4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Dec 31, 2020 at 05:10:21PM +0000, Andrew Cooper wrote:
> nestedhap_walk_L1_p2m() takes guest physical addresses, not frame numbers.
> This means the l2 input is off-by-PAGE_SHIFT, as is the l1 value eventually
> returned to the caller.
>
> Delete the misleading comment as well.
>
> Fixes: bab2bd8e222de ("xen/nested_p2m: Don't walk EPT tables with a regular
> PT walker")
> Reported-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
