Re: [PATCH 4/5] x86/xen: Don't register Xen IPIs when they aren't going to be used

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On Mon, 2021-01-04 at 11:50 -0500, boris.ostrovsky@xxxxxxxxxx wrote:
> > diff --git a/arch/x86/xen/enlighten_hvm.c
> > b/arch/x86/xen/enlighten_hvm.c
> > index a1c07e0c888e..7a6ef517e81a 100644
> > --- a/arch/x86/xen/enlighten_hvm.c
> > +++ b/arch/x86/xen/enlighten_hvm.c
> > @@ -164,10 +164,10 @@ static int xen_cpu_up_prepare_hvm(unsigned
> > int cpu)
> >        else
> >                per_cpu(xen_vcpu_id, cpu) = cpu;
> >        rc = xen_vcpu_setup(cpu);
> 
> 
> Without vector callback we will not be calling xen_vcpu_setup(0) so
> why should we still call it here for APs?

Good point. I didn't spot that because it wasn't one of the things that
actually crashed. I'll stop it doing so and retest.

Attachment: smime.p7s
Description: S/MIME cryptographic signature