[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] x86/PV: consistently inline {,un}adjust_guest_l<N>e()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 8 Jan 2021 17:56:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K96Gzt05k7XvDEEfZnEeSi9cQct+fhQoRyXwlTC0cs8=; b=RriPik58IJ/5vVdg+d0okeUJvhYZEDXnutwNLEcqLfNbRkSlNaV6HpFLFuaDbhL+aUE4J5WyzXlqNZ3jTQkkQtPRtac5azFqPFciKi2pE6nwtwWuZy/cZhjWDdpYTyAEzfsNsJ9hQXhPR1o2argh+0+2DPSFXLgePz0ongJ8Ft3UOC8WpaniyEuM/iYpEEEFUPt50aVoTEkxpI7+ajSDbWFOs/l6wjdiGGDBushQqAS7GJCxpc8LSuNgWdWGXqN/2vme+TcPfe6ONj9SRQl7ZgEZRgimseA2MGo569krleZbwFv0TJ6xCe3uB6Gmq0pIjoJV5iicogkUAWqrtvcPeg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8Bl006orONpYc0uAtiOAmT2zRzd0puHPwHBmUKM64xNojan0LDTvfg/73KoK8JnSCLF3IIV75nuADYOBLRtC+/KxIJZoTIZnUcvAcQ1nZTak6DojK3pI09hy7lXNGN4VGdj6oUcJKgfvwBSR569W+OQtKZF2Aguysm0PwR1b2QmEm9ThS9eHXhIxdm0HV4eb2emzHALhgZaPLlD91MnGfbH7KGYuZRHaO+bq2n/pcaFQBPBMclzgPAu8EwHICjOQg9p4IImkFDKRoU65QohJlSb+u3xSx7TLkgS4O+GSyjY/8C5fDTS2jgDFgDTI3ZCQqld2IcZZOOX1PHHjP5Wnw==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 08 Jan 2021 16:57:02 +0000
- Ironport-sdr: HWiQDtfFAGtp77i9NEu0AkiUUYrwHZ44PHaBImSKS6ziT6JyWMMOG42Z1qRf7TtH7mtSiPgdCt W33LO1nZVl88lWgChHtVtGbnYHDzx2rAf9gCZitffBDlwIatr18CyDp8X3DZgoAI+2NRpKEimy BRnyqGLUVRgWKqfOEyYUcJhCeTzr4UCdNgs1tlwG94CLh9MdSe2vTMaGCrsmJRKeZWXcvAxk7W fpkwCV/9Z16+8DriSgP2p525YNinMJacsnQO2ORzkZfE+tTd977Ump5vQ9WooCBw8GWGibvf5m 5mY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Nov 03, 2020 at 11:56:16AM +0100, Jan Beulich wrote:
> Commit 8a74707a7c ("x86/nospec: Use always_inline to fix code gen for
> evaluate_nospec") converted inline to always_inline for
> adjust_guest_l[134]e(), but left adjust_guest_l2e() and
> unadjust_guest_l3e() alone without saying why these two would differ in
> the needed / wanted treatment. Adjust these two as well.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
I'm also unsure why those where left without always_inline. Maybe it's
because for the way they are used?
Turning them into always_inline shouldn't do any damage, so I think
it's fine.
Thanks, Roger.
|
