Re: [PATCH 2/6] x86/mm: p2m_add_foreign() is HVM-only

[Oleksandr <olekstysh@xxxxxxxxx>]

On 12.01.21 13:58, Jan Beulich wrote:

Hi Jan.

> On 11.01.2021 09:23, Oleksandr wrote:
> > On 11.01.21 09:41, Jan Beulich wrote:
> > > If you could also provide your exact .config, I could see whether I
> > > can repro here with some of the gcc5 versions I have laying around.
> > Please see attached
> Builds perfectly fine with 5.4.0 here.
Thank you for testing.


I wonder whether I indeed missed something. I have switched to 5.4.0 
again (from 9.3.0) and rechecked, a build issue was still present.
I even downloaded 5.4.0 sources and built them to try to build Xen, and 
got the same effect.  What I noticed is that for non-debug builds the 
build issue wasn't present.
Then I decided to build today's staging 
(414be7b66349e7dca42bc1fd47c2b2f5b2d27432 xen/memory: Fix compat 
XENMEM_acquire_resource for size requests) instead of 9-day's old one when
I had initially reported about that build issue 
(7ba2ab495be54f608cb47440e1497b2795bd301a x86/p2m: Fix 
paging_gva_to_gfn() for nested virt). Today's staging builds perfectly 
fine with 5.4.0.
It seems that commit in the middle 
(994f6478a48a60e3b407c7defc2d36a80f880b04 xsm/dummy: harden against 
speculative abuse) indirectly fixes that weird build issue with 5.4.0...

--
Regards,

Oleksandr Tyshchenko