[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/dpci: remove the dpci EOI timer

  • To: Jason Andryuk <jandryuk@xxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Thu, 14 Jan 2021 11:22:05 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ObzGQVtymqLTNcnSkK1HB39ahW3a/ZBCPHsrl2e9ZQ=; b=UMJ5cGwJjQ2AR1tvK67oNdta0jsuRTS0u4P/KZ4FFEjmg10ZApVV2yO39FyX4iB27XYIcG8zTAcPcZu/b2h8a1OO7Yj6mcwjyRzWdso30RJAc22DrUkq4Jti3438vv3pZ0hArTsRyfJKpsC8WswlTo44BBUITL2MN7fdWNtzJzDUfV+Jtn2kAPHCDsC4Zvk+38JJOZ/zFOg0yDFblPXUhr5nq54PZzfj329rUY60Ornm3n4SnHrmW7HsDRq4MPGVsWj2VIvPwa4YxVJ5GIX/4EbFXSTQSjLZEmR26c5CMCyBjiYcyaVRO6xiC2jTNpQwr38gtH+5MiE/nCQgi1NZqQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFVVxo4VlWKbuJW/1iUtewkUwuY48mo4rEOjdmbhhmPHIfQFiJeGGeWujpeGcfOYlUy4R0414W0VR56C3Kcmr93/q9FChFQHuQ/giz+YRlQy43MIOVI6n98H3HRcXNvnjnndD6rLCYzTKaxMYUdF/8D6k5fHz+V5CjpxETGIVSYyzcb3GDJrlgSw8TX1RfmuWKefJb49RFm0QG/zQ/NrMEsYd5YdCMIFzVj3StBcnI0sNU7Q6kTbYZFKUe9DfC62Fqul81HglwXJrLzQiuqYueyOPfFcI5h5a58cmMqcAFOw1P9SrrPGJDQOs4xfJbrMhx3b1Tk8RI60ppHz/Xfg5A==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 14 Jan 2021 10:22:37 +0000
  • Ironport-sdr: kHh90WqaSx3+lKqDeVJOFytB7ZuJQu539IOY3oPSTfWajQkr+8uYapfH69oNaqGbLehTJT5sB/ c0uXpte+V+en5GgKkex2HO6eYlxYADnoA+EjsVXUDXjzZHGhxr7eOZOghkbc32ZOA1UI5atGAt /SRfjphgiDezB6hed8YG7KZ0q/F5UHjnE9cWIFjnPEQDFgdyCmbeBpI5DSSrzrP+oNxUng8Ges cJFkNDIkPIE5YNgUU8iHUgifw9YBEK03lsJsjh0sGANOenRCp+oKCwXBKHaP6Vt1cM92ZRFQcp DyI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Jan 13, 2021 at 04:31:33PM -0500, Jason Andryuk wrote:
> On Wed, Jan 13, 2021 at 1:34 PM Jason Andryuk <jandryuk@xxxxxxxxx> wrote:
> >
> > On Wed, Jan 13, 2021 at 1:06 PM Roger Pau Monné <roger.pau@xxxxxxxxxx> 
> > wrote:
> > >
> > > On Wed, Jan 13, 2021 at 10:48:52AM -0500, Jason Andryuk wrote:
> <snip>
> > > > I have some laptops running OpenXT where the USB controller and NIC
> > > > share an interrupt, and I assign them to different domains.  Qubes
> > > > would hit this as well.
> > >
> > > Is there any chance you could try the patch and see if you can hit the
> > > issue it was trying to fix?
> >
> > Would testing a backport to 4.12 be useful?  There were some file
> > renames, but it looks to apply.  The only difference is the 4.12
> > hvm_pirq_eoi hunk still has `(ent && ent->fields.mask) || `.  Maybe
> > backport commit eb298f32fac5ac "x86/dpci: EOI interrupt regardless of
> > its masking status" as well?

Yes, backporting that one should be harmless.

> Ok, I added these two patches to OpenXT with Xen 4.12.


> > Testing staging would take a little longer to make a machine available.
> >
> > I guess I'd also need to disable MSI for the two devices to ensure
> > they are both using the GSI?
> lspci in dom0 shows the USB xhci controller, iwlwifi, and e1000e
> devices all with IRQ 16 and all with MSI disabled ("MSI: Enabled-").
> The two linux HVMs run with (PV) linux stubdoms, and the HVM kernels
> were started with pci=nosmi.  Networking through the iwlwifi device
> works for that VM while a mouse attached to the xhci controller is
> also working in the second VM.  Is there something else I should test?

Not really, I think that test should be good enough, the issue is that
we don't know which OS was seeing the issues noted by Kevin.

To make sure you trigger the right scenario, could you start the
iwlwifi HVM guest first, and then stress test the network device
(using iperf for example) while you bring up the second VM that uses
the xhci device?

Thanks, Roger.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.