[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 03/27] tools/libxenevtchn: check xenevtchn_open() flags for not supported bits
- To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 14 Jan 2021 19:24:50 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDz4xiUlXuiHB+TEKsmn4uxiSrXCyE4MKCHUWoR8K7U=; b=f+izFOic2DrLqED3weOjhfGksI0PIZiZ4oxM2eW2QFpbE78A2zo85dC3+P8VHK2EoyLDdae8PizBGBhmMsAjEyfvBFd3Wg/CYWZt1a7XLuCCIkgGNHK2rH2Dk/B79s22U6DDV3mEEOz5pZASON58PzyzW6+A/77yotav/ANg2Cyy+RDEu+qeMD54Jq9qvMFOwYuCA1iuMDaNErJEkukUIXaL9V794VHJGIptltlPOJijbLt8xd/G9l58Sfl6/zYB06f+TtLDr2eMu6f5h8/vwX9CcQuQELRyt87yksXpXgZu/b3QEngdtgt3xu4yDRlEH9j2Xta9C/GGfIgBTbA2mg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MF7wxuC+Xk9o/U+0jaz96xYo3ZikCIwioZ6KrlP9RSGuWeIMxx5IO6OHFASve2jCQxxJ79rvs88uF8V+Qsnw/d6Q50KKFaCrUX9UUScvoCt6hV3ysTCbqvnIyGFy3bhG7TMsV9dW34jz7g/aTgzEOhab1w9qOnVIwDtzsoCK9+Fx/XSw705wCvmNAw38QwdZAvS9cE/XTde/vJRzJCZWE94sr3viyNpvezH5+bMTFeZ3we9Drxvu2kVQ74WEw4pThjRgjIB0nfj9jB3izYLBD6k5r//MLAEZBto+KO0cr9oeGjEMvKl+lUrHv/GdbLJH/UDe9CO+jJRVT5KNJGBYQg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 14 Jan 2021 19:25:06 +0000
- Ironport-sdr: 6jhYuhaTrJFe7RqaG8YH+vSKperP+o0GzE8+EhYLIl6gfYgOrfioNQeBluD9glI9YYYzUQa/Xl 6No8jLMhbrSBBLnhccDZbqFqI7ulki8az/MT4KDeuJ+H0zSaJHTblEszwgYLYyt02MsI3H7hwO 44sMG6yCvVuR29VsN7IjyQ0Mf6SBjpO513B23QGGRufwkK+7q0+AIZ27i9RRL1XiI0Kia4zXfQ DWyORH/pft8EJvC0pHVmxjTCjQG33BU1rfaX49e51pYsy88NBhYQgQPjD84BPLhJJlSgzyUbK9 POw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/01/2021 15:37, Juergen Gross wrote:
> Refuse a call of xenevtchn_open() with unsupported bits in flags being
> set.
>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Possibly worth stating that this potentially going to cause problems for
callers who were already passing junk into the flags field, but this is
far cleaner than the fallout of slowly changing the meaning of said junk
slowly as we add new parameters.
~Andrew
|
