[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] introduce unaligned.h

On 15.01.2021 12:13, Andrew Cooper wrote:
> On 15/01/2021 10:05, Jan Beulich wrote:
>> Rather than open-coding commonly used constructs in yet more places when
>> pulling in zstd decompression support (and its xxhash prereq), pull out
>> the custom bits into a commonly used header (for the hypervisor build;
>> the tool stack and stubdom builds of libxenguest will still remain in
>> need of similarly taking care of). For now this is limited to x86, where
>> custom logic isn't needed (considering this is going to be used in init
>> code only, even using alternatives patching to use MOVBE doesn't seem
>> worthwhile).
>> No change in generated code.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Iirc use of include/asm-generic/ was disliked, hence the generic header
>> goes into include/xen/.
> Really?  I think its going to be the only sane way of fixing up some of
> our header tangle.
> This series probably isn't the right place to fix this argument, so
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


> However, presumably we're going to want an ARM side of this imminently?

Why? It's only used (and going to be further used) by code not
built for Arm. So while it certainly would be nice for such a
header to also appear there (and the x86-special casing going
away in patch 2), it's not a strict requirement at this point.
Therefore I'd prefer to leave this to the Arm maintainers (and
probably for 4.16).




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.