[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libs/light: pass some infos to qemu


  • To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Sat, 16 Jan 2021 11:16:06 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WkH+fz4wAXkfkCO0Gm99rjkQOYsskXH34hpW77iZDWc=; b=AqugJm1rgm89akMGwUCFeYw4vp5dPQ6Tg1AGaWhslZgmB9Jr8TE748zQNe+0Iwnk216TUJfF6I3NGMlnOkrgQYRuVam6cU3jdzi+it5XkwxmaJR1nwzwJ9QPvky+n0hI79v9UVVsoRJON6gnp9NYPdjbl9Tf9Wrs6DGFs4B5faZtoa39vaDKah8VN7xqWmQux47F4ookLhLiGPdeNt/dtAr5seusggl9lA6Xdpa8PNCJqtA+bCiKmIRkgfHHy17Ticy9TIgRlytSt8UEO+DQLLrA5k6NBsejds5yY9Gv5FuHdcogVi459DzLis6ti2us9hoq6yFbfD/daHBcjgvMwg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fOsNtuZ62UMY3sMKqESSCk38khFcYzu3ztguwIu96Kx2/au8hkOU9389p2MV8Kev4/yzQLwL3kQh3A10kIXa9bMBhARplSjI9DokkyVzHQKAjy52l//S+sZtzkdjOo4jab63JJFQB6PEEB920AO+xkevbqkDZJXZXaKkzRF2WHTBcZt1nR9KosI0zSgSKNVZ9MQbgb/mtrNILiFKy4UmB10UOb1fHIZz3Gv7VxnN2wvPyX+TL+1qmRoszcnWRstVO6NPWHiednuMEpjKN4fAHRwS0JccymDFsJwIFuWxI+tzQ4ykXETxpsQxaBA9rcEOWmWtT50FR1AclWLrqrJzYQ==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Manuel Bouyer <bouyer@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Delivery-date: Sat, 16 Jan 2021 10:16:28 +0000
  • Ironport-sdr: XaThkaRLLh5SrRFXB7EI1t1KQn5YgPvIZKOjfnHSzHBunVsS5b/ksPLzkgUaMLlt9Ge3QXrXg5 7Hz+MONYi24ny3epgT1QZcwiM1/5rfkQ2L9nbMvQbWU9Ye+BcM5LY6edRJ8htakX3NzLrVBK21 FbErWSmX+3hIERZdfgoJEeos2xfkYS89RvAJh/GGWoJGLv6TPpvhtJpAe8vMXaQ4tH1cMwSCjz u9IWHVBFGSuqurzyQECPWuhqgi48s0v9QnFV9yjxsfIkrmTWWmZDZdMMitP8m3xKzPetU4i+xw 98Q=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Jan 12, 2021 at 07:12:37PM +0100, Manuel Bouyer wrote:
> From: Manuel Bouyer <bouyer@xxxxxxxxxx>
> 
> Pass bridge name to qemu as command line option
> When starting qemu, set an environnement variable XEN_DOMAIN_ID,
> to be used by qemu helper scripts
> 
> Signed-off-by: Manuel Bouyer <bouyer@xxxxxxxxxx>
> ---
>  tools/libs/light/libxl_dm.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tools/libs/light/libxl_dm.c b/tools/libs/light/libxl_dm.c
> index 3da83259c0..8866c3f5ad 100644
> --- a/tools/libs/light/libxl_dm.c
> +++ b/tools/libs/light/libxl_dm.c
> @@ -761,6 +761,8 @@ static int libxl__build_device_model_args_old(libxl__gc 
> *gc,
>          int nr_set_cpus = 0;
>          char *s;
>  
> +        flexarray_append_pair(dm_envs, "XEN_DOMAIN_ID", GCSPRINTF("%d", 
> domid));
> +
>          if (b_info->kernel) {
>              LOGD(ERROR, domid, "HVM direct kernel boot is not supported by "
>                   "qemu-xen-traditional");
> @@ -1547,8 +1549,10 @@ static int 
> libxl__build_device_model_args_new(libxl__gc *gc,
>                  flexarray_append(dm_args, "-netdev");
>                  flexarray_append(dm_args,
>                                   GCSPRINTF("type=tap,id=net%d,ifname=%s,"
> +                                        "br=%s,"
>                                             "script=%s,downscript=%s",
>                                             nics[i].devid, ifname,
> +                                        nics[i].bridge,

You have some hard tabs in there.

Also looking at the manual the br= option seems to only be available
for the bridge networking mode, while here Xen is using tap instead?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.