[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/4] tools/libs: Apply MSR policy to a guest

Hi Boris,

On 20/01/2021 22:49, Boris Ostrovsky wrote:
diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
index 19168572fd3e..1f2abf6679d7 100644
--- a/tools/libs/light/libxl_dom.c
+++ b/tools/libs/light/libxl_dom.c
@@ -383,9 +383,10 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
      /* Construct a CPUID policy, but only for brand new domains.  Domains
       * being migrated-in/restored have CPUID handled during the
       * static_data_done() callback. */
-    if (!state->restore)
+    if (!state->restore) {
          libxl__cpuid_legacy(ctx, domid, false, info);
+        libxl__msr_policy(ctx, domid, info);

AFAICT, this is going to break compilation of the toolst on Arm because libxl__msr_policy().

However, I am a bit unsure whether we should define a stub for this on Arm. It feels to me it would be better to pass an extra boolean (restore) to libxl__arch_domain_create() and directly implement it there.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.