[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] xl: use proper name for bash_completion file

Andrew Cooper writes ("Re: [PATCH v1] xl: use proper name for bash_completion 
> On 20/10/2020 13:39, Olaf Hering wrote:
> > Files in the bash-completion dirs should be named like the commands,
> > without suffix. Without this change 'xl' will not be recognized as a
> > command with completion support if BASH_COMPLETION_DIR is set to
> > /usr/share/bash-completion/completions.
> >
> > Fixes commit 9136a919b19929ecb242ef327053d55d824397df
> >
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> This obviously fell through the cracks, but definitely matches how
> systems are typically set up.

Technically speaking this might need a release-ack as it's enabling a
feature that was previously defeated by a bug.  I think it's fine at
this stage, so:

Release-Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.