[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 22 Jan 2021 16:07:11 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j0OCkVCXegr1PXcEcsLlm/+VGa59VAHzkqyn0tsFqyU=; b=kaudou1/CHq8yzHpOFTvVVi81EUjxxf3P9SBJVu6WxJuOVhonxlYarYVu/o6d92Q//qx32xFE2wFJhBwx6ng/Fz95M3F9qaWOtatlnESHrAk4Prf9teBRk26+AKU1gD0122nS9CWL09uUYn/UOlgp9s9gqBqMbWe1xG3MlR0NP/kLXpBmnUOF++If59UNuYgKpTcCm9EdFoHAUkVt7CK6mZEZSHy+tVQ4sXY/SvmPe/sg1DWX7qpPQ+TY+xXFx8NhM4HwMRqwI1SIRM0xZJ5sXD08GE/6nXtHgGKIzmyviUS7Ss//+Z1o5qUT9tJq+9gAyCdb25VzzB+vfwRUFv5Bw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kwyYvkgOuAhAMCRWYj5crZvMy7X7fI4Tihh0ZkpV4i0QMHdCfgyBXyIDtPVX3v1QX8Fem+tpXb6zEEmeUniSEbGao30cTWEnW8DDz6L4vUJuesl70f8o19Yu5IEr11vGxPP9+DFW+T96dPiFXe5kdCCVm5UgQ4SqxwrFOjdzlkuJy0ICoqZG2mxLbECeSAU2loLaCGnG+HQ0XmcYV1fNLt8BpY8Wj+dzi5608gs/viwmAhqjQBpPvNZ8nRLkJHIlswTMoNodn51Dun0OCCG6pjWcZpkdGP3tUmCxpE5tJ+dqZ3vTaLx33/Maa98/51Ln+MT9m9GowpTa7w/1udvwmQ==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Edwin Török <edvin.torok@xxxxxxxxxx>, "Christian Lindig" <christian.lindig@xxxxxxxxxx>, Jürgen Groß <jgross@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Fri, 22 Jan 2021 16:07:27 +0000
  • Ironport-sdr: 1Ip9kWNW+h3LGP/2TFfTzwa/fe1eVCqYHHeBQSmimZTxLlzGp/9zKklhKwYWXHNOHMlvTMk1DZ GTKaUJj6MQCW1RQYYM2J8+wVpZAV20nVDlgd0vkrWxpesq1SuzHMtHgE98H/OOtblhQMGR5Jnm pI1EGfz/HsfozQRuli+qe+6k0mpZnGCwGpJN0e/zQAXAkf5xnfOkM1RWyvN9WJEnuQk7DD5Wpp nMquoASOgPyDq9bXPFbYLC3YYhmZiD2EgeLm7PThs9se/SSM0DhsTT5jO+UAWEghrO9qP0VL/l /Po=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/01/2021 15:56, Ian Jackson wrote:
> Previously, we let the Xen build system and startup scripts choose
> which xenstored to use.  Before we upgraded to Debian buster, that
> gave us C xentored tests on ARM.  Since then, armhf and arm64 have
> both had enough ocaml support and we haven't been testing C xenstored
> at all !
> Change this, by selecting between C xenstored and Ocaml xenstored
> "at random".  Actually, this is based on the job name.  So the same
> job in different branches will use the same xenstored - which helps
> avoid confusion.
> I have diffed the output of standalone-generate-dump-flight-runvars.
> As expected, this addes a variable all_host_xenstored to every job.
> To make sure we have enough diversity, I eyeballed the results.  In
> particular:
>   * The smoke tests now have 2 C and 2 Ocaml, one of each on
>     ARM and x86.
>   * XTF tests have 2 oxenstored and 3 C xenstored.
>   * The ovmf flight has one of each
>   * The seabios and libvirt flights look reasonably mixed.
> Most other flights have enough jobs that I think things are diverse
> enough without looking at them all in detail.
> I think this lack of testing needs fixing for the Xen 4.15 release.
> So after review I intend to push this to osstest pretest, and may
> force push it even if shows regressions.

Sounds good.

A couple of quick questions/observations.  Does this cope in a sensible
way if, for whatever reason, the chosen daemon isn't present?

How hard would it be to add the 3rd option, stub-cxenstored into this
mix?  It is just one other key in xencommons to tweak.

SUPPORT.md doesn't appear to make any statements about the disposition
of xenstoreds, but stub-cxenstored is used by at least two major
downstreams so is obviously has security support in practice, and ought
to be tested.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.