[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

  • To: "iwj@xxxxxxxxxxxxxx" <iwj@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Edwin Torok <edvin.torok@xxxxxxxxxx>
  • Date: Fri, 22 Jan 2021 16:40:01 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=027SYI3Slt6ltBckZv0CMYB9vKD9vpGdCo460Du6624=; b=SPqqyFEjFD8p+HAy09e2JIMhfFhDQ9ZSqbet6cEz+F/CAOh5r4A/KNUMdkzdJg/qEYBx6sEHX1wW3dJjPfY0Lxr1p6IUwWdIEP8S7iGoFDAc9lg7Rc7x1ZEYDXKLfxZUh2QUANoZPrUJqohbmfmV5p67GfjP9HzdAau27g40F+me9YiIF1enm+dksLW28cP9rvGtMFiK3pZg3uke/3seXKZJvaa71qgCsE1peUDAm2e01yumgMPMJTJrKZmjBNOmV31z/KFQZPrfl3iLAzDYUUZhCrYadRqYKaNUjemFGFRG7e1zyt2ih5KKvKs2ZOqpvrgaEc8A0pSaIPMhfDUKbA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtddZSjAuwY04MIsQbRAi9TFYCej35rqHzmhqeC2yofaCBkR6xtRPdyd+SnCRLx3diRieDgoHMhjPfgLaOEln5DwwGmn02qEUAj+OZn22XegHmvP9S0PDHEbgy/ljA8PtodGwlDZZvpMeWIFXK06RowqhF95lK+p2L0nODkcQ3iS1F9SXrWMYwJGEmiKFeD2k8Sma4zHuk/eieDjsYDmuhiSLpObV55hE9mIzsJ6Z2UNaA1FxCr8xJ9rny0c1dBdFXoq1zH47AumcDk0JOfCdnBfqyvYhSIwU/1M2YRfk+s+fhPxiZBqNVbtx3oxUQsxeEXml9LIlJowBBoDCZ7fnQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "wl@xxxxxxx" <wl@xxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxx>, "jgross@xxxxxxxx" <jgross@xxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Delivery-date: Fri, 22 Jan 2021 16:40:08 +0000
  • Ironport-sdr: d9LZkbKrCgxaiGy8AJc+DQQkVgJ6fBKqPeZ5m5XfCqZRI9EVf5RAavXL+Vy4nkU4+RSOGoFG80 zMx5wXTkeKDmxIvZ5gDDmuVtSuKL0iJeH7YniqVtBswZsxbwBBdecaZr/AvwQV+V4vZ8ZDvwjO bn2mCctANj59oIzoqGVp8RW2lc6yQ7vLcRi0/iJ2ekc1R2wXC0jaeF+MIaLzmAQf0U3BJnaopb syhaUAQUY0BylT8sCv6a9f9YNBKW0vWqiDXM/ZlPni3ikboPv2RT7exjE23jhRsTHtjZZNkBoI JQc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHW8Nc0Pgeo5S7LXkqV4d4+1jYjq6oz2MQA
  • Thread-topic: [OSSTEST PATCH 7/7] make-flight: Stripy xenstored

On Fri, 2021-01-22 at 15:56 +0000, Ian Jackson wrote:
> Previously, we let the Xen build system and startup scripts choose
> which xenstored to use.  Before we upgraded to Debian buster, that
> gave us C xentored tests on ARM.  Since then, armhf and arm64 have
> both had enough ocaml support and we haven't been testing C xenstored
> at all !
> Change this, by selecting between C xenstored and Ocaml xenstored
> "at random".  Actually, this is based on the job name.  So the same
> job in different branches will use the same xenstored - which helps
> avoid confusion.
> I have diffed the output of standalone-generate-dump-flight-runvars.
> As expected, this addes a variable all_host_xenstored to every job.
> To make sure we have enough diversity, I eyeballed the results.  In
> particular:
>   * The smoke tests now have 2 C and 2 Ocaml, one of each on
>     ARM and x86.
>   * XTF tests have 2 oxenstored and 3 C xenstored.
>   * The ovmf flight has one of each
>   * The seabios and libvirt flights look reasonably mixed.
> Most other flights have enough jobs that I think things are diverse
> enough without looking at them all in detail.
> I think this lack of testing needs fixing for the Xen 4.15 release.
> So after review I intend to push this to osstest pretest, and may
> force push it even if shows regressions.

Sounds good.

In the patch series that I've recently posted to xen-devel there is
also a 'make check' target in tools/ocaml/xenstored.

There is a bit of plumbing to do before that is ready to be run
automatically (there is a Dockerfile in the patchseries, so it should
be possible to either adapt that, or vendor the 3rdparty dependencies
for the purposes of osstest, whichever is preferable).

These unit tests require OCaml 4.06+, so it'd be good to ensure that at
least one of the builders has that (the Ubuntu:focal from my patch
series should).

Best regards,



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.