[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 00/11] domain context infrastructure


  • To: Paul Durrant <paul@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 25 Jan 2021 20:15:34 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIf/n6e34fgdxuKVqqmGKol0LKI4iJsI2dpHFUSh1EM=; b=EAHLloYKRv06vQ5TIddsPljiMH77IvmdvUcdw790f0ZUQAVoiiQI7jkTppFLFjVufz5cUhb84dL/MdVxZ1r8rsDUkQtxlabSWNlp4E6f5UgVbeIptj/kuv9kBXEAbAjQqE91NqPtBDozaX+JDmsMiqabMER3SLlSeYjODadzURSNUEXOFW5ine+q4xXTt4P7X0V1xmc77w40syOZbWWr3O/YqpzQ4XQXzhfg7wVWjI3n0kzUrLcVvlEETcmxR+rHpsrCGhk10QmhTUEZL46TbfyoKFQ6kIF7/D1XT04YarDAkNr8eLeJIh1amCzsqBWLzlrWNHVlJsBdQ3vyT3MuwQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B+SzA8Rpl29ulnIvyrZ92h2rvo1kcgpAOq74lE04/IPojB6vlwo+8qpho/uWGrDEYX0qX+AHCu+Vurdc3MK1cNT+P+AK2riS6XOb5jO42NTmW+kEUzWSZ3lZLkgY7NdeD43CGP2dkUXeAcjJBo19px+cxXvBpF6wCTiYkjDRSuJbnkXJUzAI0yxQBU9y29b5ESkLUpy/GTtsPposwiAFc/cdxJWW2AryPrPu69D4vFtRRm7Q1IiYiT5fQpWuzRKxN5UEgEOf8L+AGWdeKBjLkhGEAggX7FiTuJUobiCoKwNK6hZnqP0KtefE9bZn10WzcjKPTL25C8CYKOWfs1rJLw==
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Paul Durrant <pdurrant@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 25 Jan 2021 20:15:50 +0000
  • Ironport-sdr: WbURBHPqUwcawkwdVqIUx0pV0gTlJ8EZjQPL/SFEfnh2q8IeqFGpbbzWl6F8Na65+BQTikcr0q l8WTO3asUi+pmhMECNo3pCpHywpqoW/or40Ku0UzC7J6E41geB1g9OlN8lqwrrOa0r6XJOYXgu t/YY6A/Gjn5SKglPWVqdna/n8gf/skSjNrZG0ErpRaU/M8g58l/igEWbIWhiWnwtneMTBRWaSu yT0npZYVnXdQdxTPrOTyXUqukbUlT6bgJlSrVu2D7eqSfcd1jjoaPi6Dvfu2YnXCU0SGwbhf1A TI4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08/10/2020 19:57, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@xxxxxxxxxx>
>
> Paul Durrant (11):
>   docs / include: introduce a new framework for 'domain context' records
>   xen: introduce implementation of save/restore of 'domain context'
>   xen/common/domctl: introduce XEN_DOMCTL_get/set_domain_context
>   tools/misc: add xen-domctx to present domain context
>   common/domain: add a domain context record for shared_info...
>   x86/time: add a domain context record for tsc_info...
>   docs/specs: add missing definitions to libxc-migration-stream
>   docs / tools: specify migration v4 to include DOMAIN_CONTEXT
>   tools/python: modify libxc.py to verify v4 stream
>   tools/libs/guest: add code to restore a v4 libxc stream
>   tools/libs/guest: add code to save a v4 libxc stream

Thanks - this is much better when it comes to the public API/ABI.

However, my concerns still stands.  What *else* is going in the domain
context record, because you can pull the "bump the interface version and
deprecated new fields" exactly once, as the libxg logic doesn't delve
into domain context stream.

At the moment this does increase the downtime of the VM for no gain. 
What I'm trying to understand is whether this is "no gain (yet)" or
whether you consider this "done" as far as cooperative migrate is concerned.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.