[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 02/15] libxenguest: support zstd compressed kernels



Jan Beulich writes ("[PATCH v3 02/15] libxenguest: support zstd compressed 
kernels"):
> This follows the logic used for other decompression methods utilizing an
> external library, albeit here we can't ignore the 32-bit size field
> appended to the compressed image - its presence causes decompression to
> fail. Leverage the field instead to allocate the output buffer in one
> go, i.e. without incrementally realloc()ing.
> 
> As far as configure.ac goes, I'm pretty sure there is a better (more
> "standard") way of using PKG_CHECK_MODULES(). The construct also gets
> put next to the other decompression library checks, albeit I think they
> all ought to be x86-specific (e.g. placed in the existing case block a
> few lines down).
> 
> Note that, where possible, instead of #ifdef-ing xen/*.h inclusions,
> they get removed.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Wei Liu <wl@xxxxxxx>
> Release-Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> ---
> Note for committer: As an alternative to patching tools/configure here,
> autoconf may want re-running.

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks,
Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.