Re: [PATCH V5 00/22] IOREQ feature (+ virtio-mmio) on Arm

[Oleksandr <olekstysh@xxxxxxxxx>]

On 27.01.21 19:42, Julien Grall wrote:

Hi

> On 27/01/2021 17:37, Oleksandr wrote:
> > On 27.01.21 19:33, Julien Grall wrote:
> >
> > Hi Julien
> >
> > > On 27/01/2021 16:50, Oleksandr wrote:
> > > > On 27.01.21 18:43, Julien Grall wrote:
> > > > > Hi Oleksandr,
> > > > Hi Julien
> > > >
> > > >
> > > > > On 25/01/2021 19:08, Oleksandr Tyshchenko wrote:
> > > > > > ***
> > > > > >
> > > > > > Patch series [8] was rebased on recent "staging branch"
> > > > > > (5e31789 tools/ocaml/libs/xb: Do not crash after xenbus is 
> > > > > > unmapped) and tested on
> > > > > > Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio 
> > > > > > disk backend [9]
> > > > > > running in driver domain and unmodified Linux Guest running on 
> > > > > > existing
> > > > > > virtio-blk driver (frontend). No issues were observed. Guest 
> > > > > > domain 'reboot/destroy'
> > > > > > use-cases work properly. Patch series was only build-tested on x86.
> > > > > >
> > > > > > Please note, build-test passed for the following modes:
> > > > > > 1. x86: CONFIG_HVM=y / CONFIG_IOREQ_SERVER=y (default)
> > > > > > 2. x86: #CONFIG_HVM is not set / #CONFIG_IOREQ_SERVER is not set
> > > > > > 3. Arm64: CONFIG_HVM=y / CONFIG_IOREQ_SERVER=y
> > > > > > 4. Arm64: CONFIG_HVM=y / #CONFIG_IOREQ_SERVER is not set (default)
> > > > > > 5. Arm32: CONFIG_HVM=y / CONFIG_IOREQ_SERVER=y
> > > > > > 6. Arm32: CONFIG_HVM=y / #CONFIG_IOREQ_SERVER is not set (default)
> > > > > I thought I woudl give a try to test the code, but I can't find a 
> > > > > way to enable CONFIG_IOREQ_SERVER from the UI.
> > > > > Looking at the Kconfig, it looks like CONFIG_IOREQ_SERVER doesn't 
> > > > > have a prompt and is not selected by Arm.
> > > > > Can you provide details how this can be built on Arm?
> > > > Please apply the attached patch to select IOREQ on Arm.
> > > This is roughly what I wrote. I think a user should be able to 
> > > select IOREQ via the menuconfig without any additional patch on top 
> > > of your series.
> > > Can you include a patch that would enable that?
> > Yes, do you prefer a separate patch or required changes could be 
> > folded in patch #14?
> I would do a separate patch as IOREQ only really work after the full 
> series applies.

Makes sense, I will do it for V6


--
Regards,

Oleksandr Tyshchenko