Re: [PATCH V5 04/22] xen/ioreq: Make x86's IOREQ feature common

[Julien Grall <julien@xxxxxxx>]

On 25/01/2021 23:40, Oleksandr wrote:
> On 26.01.21 01:13, Julien Grall wrote:
> > Hi,
> Hi Julien
Hi Oleksandr,

> > On Mon, 25 Jan 2021 at 19:09, Oleksandr Tyshchenko 
> > <olekstysh@xxxxxxxxx> wrote:
> > > ***
> > > Please note, this patch depends on the following which is
> > > on review:
> > > https://patchwork.kernel.org/patch/11816689/
> > > The effort (to get it upstreamed) was paused because of
> > > the security issue around that code (XSA-348).
> > > ***
> > I read this comment as "This series should be applied on top the patch
> > X". However, looking at your branch, I can't see the patch. What did I
> > miss?
> You didn't miss anything. Patch series doesn't contain it. I mentioned 
> about this patch in order not to forget about it
> and draw reviewer's attention. Looks like, the activity (to get it 
> upstreamed) hasn't been resumed yet and I don't know what we should do 
> with that dependency
> in the context of this series...
I will reply what I wrote on IRC privately :). I think this fine to 
defer it to after Xen 4.15 because IOREQ will be in tech preview.
Note that the bug can only be hit if the IOREQ server disappear behind 
your back. AFAICT, this is mostly an issue with device model running in 
non-trusted domain.
Cheers,

--
Julien Grall