|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH V5 10/22] xen/ioreq: Move x86's io_completion/io_req fields to struct vcpu
Hi Oleksandr, On 25/01/2021 19:08, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> The IOREQ is a common feature now and these fields will be used on Arm as is. Move them to common struct vcpu as a part of new struct vcpu_io and drop duplicating "io" prefixes. Also move enum hvm_io_completion to xen/sched.h and remove "hvm" prefixes. This patch completely removes layering violation in the common code. Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx> Reviewed-by: Paul Durrant <paul@xxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> CC: Julien Grall <julien.grall@xxxxxxx> [On Arm only] Tested-by: Wei Chen <Wei.Chen@xxxxxxx> I seem to have trouble running Xen on x86 platform after this patch is applied (see trace below). The bisector pointed out to this patch but I can't quite figure out why this is breaking. Does this ring any bell to someone? (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) (XEN) ----[ Xen-4.15-unstable x86_64 debug=n gcov=y Tainted: C ]---- (XEN) CPU: 1(XEN) RIP: e008:[<ffff82d04041c1c7>] x86_64/entry.S#restore_all_guest+0x7/0x145 (XEN) RFLAGS: 0000000000010002 CONTEXT: hypervisor (d0v0) (XEN) rax: 00000000000000ff rbx: ffff83027c806000 rcx: ffff82d0406c9a80 (XEN) rdx: 0000000000000000 rsi: fffffffffffffed9 rdi: 0000000000000001 (XEN) rbp: ffff83027c887df0 rsp: ffff83027c887ef8 r8: 00000000aaa8946e (XEN) r9: 0000000000000002 r10: ffff83027c806040 r11: ffff83027c8cc020 (XEN) r12: ffff83027c80f000 r13: ffff83027c895000 r14: 0000000000000000 (XEN) r15: 0000000000000000 cr0: 0000000080050033 cr4: 00000000003426e0 (XEN) cr3: 0000000273a2d000 cr2: 0000000000000000 (XEN) fsb: 0000000000000000 gsb: 0000000000000000 gss: 0000000000000000 (XEN) ds: 0000 es: 0000 fs: 0000 gs: 0000 ss: 0000 cs: e008(XEN) Xen code around <ffff82d04041c1c7> (x86_64/entry.S#restore_all_guest+0x7/0x145): (XEN) 00 48 8b 93 98 0d 00 00 <44> 8b 3a 4c 8b 8b 68 0b 00 00 ba ff 7f 00 00 48 (XEN) Xen stack trace from rsp=ffff83027c887ef8: (XEN) 0000000000000000 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000000000000 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000000000000 0000000000000000 0000000000000000 0000000000000000 (XEN) 0000000000000000 ffffffff83a2c000 0000000000000000 0000000000000000 (XEN) ffffffff82c9e160 000000000000e033 0000000000000200 ffffffff83a4f000 (XEN) 000000000000e02b 0000000000000000 0000000000000000 00000000ffffffff (XEN) 0000000000000000 0000e01000000001 ffff83027c806000 000000323c1d9000 (XEN) 00000000003426e0 0000000000000000 0000000000000000 0000060100000000 (XEN) 0000000000000000 (XEN) Xen call trace: (XEN) [<ffff82d04041c1c7>] R x86_64/entry.S#restore_all_guest+0x7/0x145 (XEN) (XEN) Pagetable walk from 0000000000000000: (XEN) L4[0x000] = 0000000000000000 ffffffffffffffff (XEN) Xen lock profile info SHOW (now = 4770175959 total = 4770175959) (XEN) Global xenpf_lock: addr=ffff82d04052c4a0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global rtc_lock: addr=ffff82d04052c480, lockval=00010001, not locked (XEN) lock:0(0), block:0(0) (XEN) Global pit_lock: addr=ffff82d04052c470, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global platform_timer_lock: addr=ffff82d04052c460, lockval=000e000e, not locked (XEN) lock:6(57390), block:0(0) (XEN) Global sync_lock: addr=ffff82d04052c440, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global lock: addr=ffff82d04052c450, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global flush_lock: addr=ffff82d04052c430, lockval=00080007, cpu=0 (XEN) lock:3(49953), block:0(0)(XEN) Global pci_config_lock: addr=ffff82d04052c420, lockval=22702270, not locked (XEN) lock:14(100313), block:0(0)(XEN) Global lapic_nmi_owner_lock: addr=ffff82d04052bff0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global map_pgdir_lock: addr=ffff82d04052bfd0, lockval=00050005, not locked (XEN) lock:3(386), block:0(0)(XEN) Global vector_lock: addr=ffff82d04052bfc0, lockval=00260026, not locked (XEN) lock:1(383), block:0(0)(XEN) Global irq_ratelimit_lock: addr=ffff82d04052bfb0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global lock: addr=ffff82d04052bf90, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global msix_fixmap_lock: addr=ffff82d04052bf80, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global ioapic_lock: addr=ffff82d04052bf60, lockval=003a003a, not locked (XEN) lock:0(0), block:0(0)(XEN) Global i8259A_lock: addr=ffff82d04052bf50, lockval=00210021, not locked (XEN) lock:0(0), block:0(0) (XEN) Global osvw_lock: addr=ffff82d04052bf10, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global vpmu_lock: addr=ffff82d04052bf00, lockval=00040004, not locked (XEN) lock:4(449), block:0(0) (XEN) Global mtrr_mutex: addr=ffff82d04052bcf0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global set_atomicity_lock: addr=ffff82d04052bce0, lockval=00040004, not locked (XEN) lock:0(0), block:0(0)(XEN) Global microcode_mutex: addr=ffff82d04052bcc0, lockval=00030003, not locked (XEN) lock:0(0), block:0(0)(XEN) Global cmci_discover_lock: addr=ffff82d04052bc90, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global mce_logout_lock: addr=ffff82d04052bc70, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global processing_lock: addr=ffff82d04052bc50, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global pm_lock: addr=ffff82d04052bbc0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global apei_iomaps_lock: addr=ffff82d04052bbb0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global erst_lock: addr=ffff82d04052bba0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global shared_intremap_lock: addr=ffff82d04052bb20, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global console_lock: addr=ffff82d04052b7d0, lockval=01350135, not locked (XEN) lock:154(111298857), block:0(0)(XEN) Global ratelimit_lock: addr=ffff82d04052b7c0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global lock: addr=ffff82d04052b7a0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global sched_free_cpu_lock: addr=ffff82d04052b770, lockval=00040004, not locked (XEN) lock:4(2963), block:0(0)(XEN) Global cpupool_lock: addr=ffff82d04052b750, lockval=00030003, not locked (XEN) lock:3(19403), block:0(0)(XEN) Global sysctl_lock: addr=ffff82d04052b740, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global domctl_lock: addr=ffff82d04052b730, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global pool_list_lock: addr=ffff82d04052b720, lockval=00010001, not locked (XEN) lock:0(0), block:0(0)(XEN) Global xenoprof_lock: addr=ffff82d04052b710, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global pmu_owner_lock: addr=ffff82d04052b700, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global vm_lock: addr=ffff82d04052b6f0, lockval=00130013, not locked (XEN) lock:0(0), block:0(0)(XEN) Global virtual_region_lock: addr=ffff82d04052b6e0, lockval=00010001, not locked (XEN) lock:1(198), block:0(0) (XEN) Global wc_lock: addr=ffff82d04052b6d0, lockval=00020002, not locked (XEN) lock:1(770), block:0(0)(XEN) Global tasklet_lock: addr=ffff82d04052b6c0, lockval=03790379, not locked (XEN) lock:612(52925), block:0(0)(XEN) Global symbols_mutex: addr=ffff82d04052b6b0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global stopmachine_lock: addr=ffff82d04052b6a0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global call_lock: addr=ffff82d04052b680, lockval=00040004, not locked (XEN) lock:3(27688741), block:0(0) (XEN) Global lock: addr=ffff82d04052b560, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global heap_lock: addr=ffff82d04052b540, lockval=c5d0c5d0, not locked (XEN) lock:16949(5481440), block:1(34420)(XEN) Global crash_notes_lock: addr=ffff82d04052b520, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) Global lock: addr=ffff82d04052b500, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global global_virq_handlers_lock: addr=ffff82d04052b4f0, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global domlist_update_lock: addr=ffff82d04052b4d0, lockval=00010001, not locked (XEN) lock:1(105), block:0(0)(XEN) Global debugtrace_lock: addr=ffff82d04052b4b0, lockval=00030003, not locked (XEN) lock:3(3327), block:0(0)(XEN) Global accounting_lock: addr=ffff82d04052b480, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Global efi_rs_lock: addr=ffff82d04052b020, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 0 event_lock: addr=ffff83027c80f110, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 0 page_alloc_lock: addr=ffff83027c80f028, lockval=05cf05cf, not locked (XEN) lock:1487(3914530), block:0(0)(XEN) Domain 0 domain_lock: addr=ffff83027c80f018, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 32767 page_alloc_lock: addr=ffff83027c875028, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 32767 domain_lock: addr=ffff83027c875018, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 32753 page_alloc_lock: addr=ffff83027c8c8028, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 32753 domain_lock: addr=ffff83027c8c8018, lockval=00000000, not locked (XEN) lock:0(0), block:0(0)(XEN) Domain 32754 page_alloc_lock: addr=ffff83027c8c9028, lockval=18001800, not locked (XEN) lock:6144(101574), block:0(0)(XEN) Domain 32754 domain_lock: addr=ffff83027c8c9018, lockval=00000000, not locked (XEN) lock:0(0), block:0(0) (XEN) debugtrace_dump() global buffer starting 1 cpupool_create(pool=0,sched=0) 2 Created cpupool 0 with scheduler SMP Credit Scheduler rev2 (credit2) 3 cpupool_add_domain(dom=0,pool=0) n_dom 1 rc 0 (XEN) wrap: 0 (XEN) debugtrace_dump() global buffer finished (XEN) (XEN) **************************************** (XEN) Panic on CPU 1: (XEN) FATAL PAGE FAULT (XEN) [error_code=0000] (XEN) Faulting linear address: 0000000000000000 (XEN) **************************************** Cheers, -- Julien Grall
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |