Re: more randconfig failures

[Julien Grall <julien@xxxxxxx>]

On 27/01/2021 23:11, Rahul Singh wrote:
> Hello Julien,
Hi Rahul,

> > On 27 Jan 2021, at 9:25 pm, Julien Grall <julien.grall.oss@xxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On Wed, 27 Jan 2021 at 21:16, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
> > > Hi all,
> > >
> > > These are two recent randconfig build failures reported by gitlab (the
> > > two patches that triggered the CI-loop are two patches to the
> > > MAINTAINERS file -- certainly not the cause of the build issues):
> > >
> > > x86 randconfig failure:
> > > https://gitlab.com/xen-project/patchew/xen/-/jobs/990347647
> > >
> > > arm randconfig failure:
> > > https://gitlab.com/xen-project/patchew/xen/-/jobs/990335472
> > make[5]: Leaving directory '/builds/xen-project/patchew/xen/xen/common/libfdt'
> > smmu-v3.c: In function 'acpi_smmu_get_options':
> > smmu-v3.c:3017:7: error: 'ACPI_IORT_SMMU_V3_CAVIUM_CN99XX' undeclared
> > (first use in this function)
> > 3017 |  case ACPI_IORT_SMMU_V3_CAVIUM_CN99XX:
> >       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > smmu-v3.c:3017:7: note: each undeclared identifier is reported only
> > once for each function it appears in
> > smmu-v3.c:3020:7: error: 'ACPI_IORT_SMMU_V3_HISILICON_HI161X'
> > undeclared (first use in this function)
> > 3020 |  case ACPI_IORT_SMMU_V3_HISILICON_HI161X:
> >       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >   INIT_O  efi-dom0.init.o
> > smmu-v3.c: In function 'arm_smmu_device_acpi_probe':
> > smmu-v3.c:3035:36: error: implicit declaration of function
> > 'dev_get_platdata' [-Werror=implicit-function-declaration]
> > 3035 |  node = *(struct acpi_iort_node **)dev_get_platdata(dev);
> >       |                                    ^~~~~~~~~~~~~~~~
> > smmu-v3.c:3035:36: error: nested extern declaration of
> > 'dev_get_platdata' [-Werror=nested-externs]
> > smmu-v3.c:3035:10: error: cast to pointer from integer of different
> > size [-Werror=int-to-pointer-cast]
> > 3035 |  node = *(struct acpi_iort_node **)dev_get_platdata(dev);
> >       |          ^
> > ld    -EL  -r -o built_in.o memcpy.o memcmp.o memmove.o memset.o
> > memchr.o clear_page.o bitops.o find_next_bit.o strchr.o strcmp.o
> > strlen.o strncmp.o strnlen.o strrchr.o
> > cc1: all warnings being treated as errors
> >
> > It looks like the SMMUv3 driver has not been built tested with
> > CONFIG_ACPI=y.  Bertrand, Rahul, can you take a look?
> Sorry my mistake I didn’t enable the ARM_SMMU_V3 with ACPI and tested the 
> compilation.
>
> There are two option to fix this:
>
> 1. #undef-ining the CONFIG_ACPI in the smmu-v3.c file and fix the compilation. 
> In this case once we have ACPI IORT table code ported to XEN smmu-v3 code can 
> be used at that time.
> 2.  Remove the arm_smmu_device_acpi_probe() from the smmu-v3.c now and once we 
> have  ACPI IORT table code ported to XEN we can add it back.
How about the following?

3. Only allow the user to build the SMMUv3 when !CONFIG_ACPI.

Cheers,

--
Julien Grall