[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/HVM: re-order error path of hvm_domain_initialise()

On 28.01.2021 17:51, Andrew Cooper wrote:
> On 28/01/2021 14:40, Jan Beulich wrote:
>> hvm_destroy_all_ioreq_servers(), called from
>> hvm_domain_relinquish_resources(), invokes relocate_portio_handler(),
>> which uses d->arch.hvm.io_handler. Defer freeing of this array
>> accordingly on the error path of hvm_domain_initialise().
>> Similarly rtc_deinit() requires d->arch.hvm.pl_time to still be around,
>> or else an armed timer structure would get freed, and that timer never
>> get killed.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>


>> ---
>> We may want to consider moving the other two XFREE()s later as well,
>> if only to be on the safe side.
> Wherever possible, I want to move stuff like this into the idempotent
> domain_teardown()/_domain_destroy() logic, although I suspect you want
> this suitable for backport as well?

This and I didn't want it more involved than necessary at this point.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.