[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libs/light: pass some infos to qemu
- To: Manuel Bouyer <bouyer@xxxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 1 Feb 2021 09:06:13 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=76t+WtlYL8DogoPuNoWMKZ2EhhsETnF01kV83mi7V80=; b=PGz76xqVJd5PfddOQR1S2TC2+fgp63/hBZGY6H70KjZDQ5IsZi3eEFtVu/cL/ANBEoz2aW0wqrLyXMQ+M5oC0OB3rdi+ggdpPNSfr4wFUKpu7IQJ9w3EbIUjgZ6C/Lcxp/pH6VOWaQkSwwI50/55snact7gaNaGbvmPC5DqMLeQbfsKPNBgeuSyXmYf4V6fjIH7noJhhxg3RbuJcL7qx/uwU0ZgykwmkYUml8cjHhF4bEKnQfv8kH9HwocEpN5Ijhu3QvQzFYQocz0gVLdlwhiSRvGOD2qonPUYEv8CEaUxiweYF1GfHJED/gz9KU3/l3B9wd2IHCqrObblyRJNZmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhHi7/7PtDTNYkof8eCQZuw6jMJEclgIOhxXr50FIXg81NfrX5nGCj5nMoQKR+q+0PCJfHPqrHAG/NGJ8kP7nXFBEgb9C0jioav1wBmFAt4bR9eAUEYNCNPrr6ZUwe+N/RyPfOQKY9n2mLkEjL/npSBryYQ3D8txdXY0FVij8VdRid/MY5gGcvNbnGnUXwb/DCAPr3jHwd5HOWLJEd8O5c8ttvvhHugX41atZJ6DvtXynzhLFzhTNgThpS2SaDLB4gMee1D8aCjok9PxmMhY74n9nXCwpIjRvVS4+Mc7CalIgItYMC3rdTmpSTVUG4tf07lCEJEF8F03hztj3WeSsw==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Mon, 01 Feb 2021 08:06:49 +0000
- Ironport-sdr: v798ru2Si4AMC9Me2Z4zh+chcNpz/rjcaVN/dMgxcjX7N5IM96Pz7zQyizjrztr69PmVJs/Q/a YrkYwPsy6yixEQqPyzJ/8k70v0wlN5lHPWhM7IGcZBOr3ohf7tCcCDCNctHz/HoWn7HtZcM+4V V37LTxSYhg5BzgLPjcDDdiv3jvvdXHGoBVjUPaJlfwRSwL92VYzYEoWxdXh0E9Aa9aZNif2Hk4 7jJSqrnaj4AKO7enrNp4Tt0MBtwLWl2Q7qp0XovLWtfo12Zc6gKpQ5NTPR5ItJr649NIoJyMQn qWA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat, Jan 30, 2021 at 12:50:13PM +0100, Manuel Bouyer wrote:
> On Thu, Jan 28, 2021 at 12:08:02PM +0100, Roger Pau Monné wrote:
> > [...]
> > Also, the qemu-ifup script doesn't seem to be part of the NetBSD
> > scripts that are upstream, is this something carried by the NetBSD
> > package?
>
> Actually, the script is part of qemu-xen-traditional:
> tools/qemu-xen-traditional/i386-dm/qemu-ifup-NetBSD
>
> and it's installed as part of 'make install'. The same script can be used
> for both qemu-xen-traditional and qemu-xen as long as we support only
> bridged mode by default.
>
> qemu-xen-traditional did call the script with the bridge name.
> This patch makes qemu-xen call the script with the same parameters,
> and add the XEN_DOMAIN_ID environnement variable.
>
> Is it OK to keep the script from qemu-xen-traditional (and installed as
> part of qemu-xen-traditional) for now ?
I think you want to move the script into hotplug/NetBSD/ because it
should be possible to install a system without qemu-xen-traditional
(--disable-qemu-traditional) and only qemu-upstream, and the script
will still be needed in that case.
Thanks, Roger.
|
