[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xenstore: Fix all builds


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 2 Feb 2021 10:19:55 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3/gmgu9GdMiIcGKeSjmPU54VuSLrpAkpme844jmWvr4=; b=GBSvQlYn5jbPC/1h5j4nzyd7wbhgPha8g9Ge5g015XjJNYFrrRjBVBffohak3wxFEJNsG9JGT6p/UtWr15zuFG62huBQf252sII6g9ST0wi2uTKTcNGzEDTaqyDZrzIWP4d8Zm4nUT1RMFlBXLag6cBG1OeUT4lurKTR+14oTGEfkI0pfedj5DpE0T6dVvoddMbA2zraDmrW7SXA8Li+Utegm+OSeuK3HT2+xrmBACSEJw3bReTuCs/cYluytSlN8FLjQyUqK5AuuftKZquTyq4zIdAJppJRRiyrKECA0lHgFhxMOqY6KCRiz8nl+MtHZK1Nbt3lsU4g7nFmhhvdtQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBoAP88Q+CmLZ/+f60jQeqq2dhFTgzgg2fmRtN18Uc8MOkCR826pUvgH2Cj+dZNWo/MoHKGSPZEPIWTKMhdpcB4yjNHg1rpHdOKMWKZnGI/beDkW/Qxkxl0NfiwIJXmLvDIeNKy2mCbLr0SOx+BAtVXtZ/8BBZUSjmkzYAyszVjmhG3yqyYrfaxEom/AQDFcklmIFhtm+1c0aV3VuLr9pXBn0b10a/ZDgx82l1EyNkND11Q9KMjXOeZxkrDGSkiJO3KIdreR1SSmsd5PIWHawkZlKjYcGoVTOrhBKPObsMJ89niq68oorzs/bGtPnuTEq9i7sOG7U3fsTGDw9whwyg==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • Delivery-date: Tue, 02 Feb 2021 09:20:26 +0000
  • Ironport-sdr: 4ji27tSKyerhD8pdwJKNEkWpvrlmc1GBAwHSZymylFBw+mAefh3e89drl8HQzhcjcMdYH4lZHl tXobT1gqcdqk4OSiXVYswZGOI+AAPsr9tLntVyjWLbaeh+hGJFoSylDdQdTqK7XGpd5neAtujg vtURDdh5WhilQdEprGN1XJkAdD1FPdsBSmNgyArz/52JhxJ4+/cgOq6jFq44DwX/suFNuyvI6e mql51KvZAGED8RsMxCFuA557rK0+OAAJTig5zsE12Q0FSG7E3YqYPwBepfwfVJ/MA+RO2ar7sO 6Co=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Feb 01, 2021 at 11:35:13PM +0000, Andrew Cooper wrote:
> This diff is easier viewed through `cat -A`
> 
>   diff --git a/tools/xenstore/include/xenstore_state.h 
> b/tools/xenstore/include/xenstore_state.h$
>   index 1bd443f61a..f7e4da2b2c 100644$
>   --- a/tools/xenstore/include/xenstore_state.h$
>   +++ b/tools/xenstore/include/xenstore_state.h$
>   @@ -21,7 +21,7 @@$
>    #ifndef XENSTORE_STATE_H$
>    #define XENSTORE_STATE_H$
>    $
>   -#if defined(__FreeBSD__) ||M-BM- defined(__NetBSD__)$
>   +#if defined(__FreeBSD__) || defined(__NetBSD__)$
>    #include <sys/endian.h>$
>    #else$
>    #include <endian.h>$
> 
> A non-breaking space isn't a valid C preprocessor token.
> 
> Fixes: ffbb8aa282de ("xenstore: fix build on {Net/Free}BSD")

Sorry. I fixed this locally but forgot to refresh the patch and ended
up sending the broken version. I need to figure a way to make
format-patch fail if there are uncommitted changes in the repository.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.