Re: xenstored file descriptor leak

[Jürgen Groß <jgross@xxxxxxxx>]

On 03.02.21 13:33, Manuel Bouyer wrote:
> On Wed, Feb 03, 2021 at 01:21:59PM +0100, Jürgen Groß wrote:
> > > Will do
> > >
> > > In the patch I'm going to submit, may I add
> > >
> > > Reviewed-by: Jürgen Groß <jgross@xxxxxxxx>
> > > ?
> > Let me see the patch (including commit message) first, please.
> >
> > So just send out as a regular patch, and I'll respond accordingly. :-)
> Attached is the new patch.
>
> As commit message I suggest:
>
> xenstored: close socket connections on error
>
> On error, don't keep socket connection in ignored state but close them.
> When the remote end of a socket is closed, xenstored will flag it as an
> error and switch the connection to ignored. But on some OSes (e.g.
> NetBSD), poll(2) will return only POLLIN in this case, so sockets in ignored
> state will stay open forever in xenstored (and it will loop with CPU 100%
> busy).
Uh, this is no regular patch. You've sent correct patches before,
haven't you? The patch should have a Signed-off-by: and in this case a
Fixes: tag as well (hint: the patch breaking your use case was
commit d2fa370d3ef9cbe22d7256c608671cdcdf6e0083). See

https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature