[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] NetBSD: use system-provided headers
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 3 Feb 2021 19:27:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p4dcvWQS3pySTSt+XdeIGhGDdTXQFonS/J+U2VJyU6M=; b=Yx7rlanD6bS0RPwcS3hJ9TYm6ppNY3BKoJewTBBT1n3U49FH50MJ+CcXQ+Ml6L1qdR4LRVf5V9ntDn6eBafMKkh4AdApP1B1oOuFagBYn3Mjg8PyBAOvnOAX0wrgvVwfwTQYrRAQcy120sNcWthLV4zkWMKOwCrD+50BFKFldRssfQMr/OkbLg2YeKVE3a8nKYJ5HP4P3zBE5YG1Fi8hHatsXZb+jMiyFaRKUY2PN1is9KbumxnY7liU0B2CfqdHUnWfN8QF6KFGmuTqEwXguVWrC8Q03VcGnvS1zxq9R1WKgzm2joIboA4NPW20opCy72rn/d6fZoz0a0JK8J/bLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4jlGYzPHH/Y/dEl0bdsYVFHxwMe42EYxS1rwuiqr2anVo0cFU2NqYMEKMImaEF/M8yfrjn0sUOY8G1rtnpezEu22ZH/kAYilH6YK7bbL/VMHjqOebrXRBcd6/nZaaC9WYnjGdqJwub5igmgZvsnur3oSQJSZl8efh/2EwhbOc18G5pnbafIjDCKPVrd8bdbBrYyMlWnoebkCAGMG4oZFC3AWWoWk/t/Kj0ETTrZe6WQKmBjjYeNVmlyxp0nLOK6FdX39mgwRpr7wprT56HO6F6L9IL2h5dRYQs+j99dO/AkWmzG5/d1aWSy5JSjKjqV/anSNb+XehVvgPznpKOQhg==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Manuel Bouyer <bouyer@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Elena Ufimtseva" <elena.ufimtseva@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 03 Feb 2021 18:28:02 +0000
- Ironport-sdr: 1CnpsB47DER3/O/js1NieQnMx0ISOHvm49TdGH4pWLIblRVqU4UQh8SH4Fnbjd0gMS+R1phFFD 3LJyxetsHLm0bDc6jO/rQ79CJhMGd76lbBVO0TqoVxoJCKsUhf9Kk5iG9lWhYKTuk8CXNjMgq+ 86MeBeXGUNyW7fqbAwQ+b6nz75mUuvsMY9D0xe+13Uar9l381HOMjmzvI+b/FCfa6w3gZ1VYAZ MXEof5tYy17z08gLhgF37QRwz8EM/mmmc+KVsJ+UYW7/MLgQOt4dTmSZ5f0m90gGIotC5ht4wd y34=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Feb 03, 2021 at 05:26:44PM +0000, Ian Jackson wrote:
> Manuel Bouyer writes ("[PATCH v3] NetBSD: use system-provided headers"):
> > +#ifdef __NetBSD__
> > +#include <xen/xenio.h>
> > +#else
> > #include <xen/sys/privcmd.h>
> > +#endif
> > #include <xen/foreign/x86_32.h>
> > #include <xen/foreign/x86_64.h>
> Maneul, thanks. I think this is a bugfix and ought in principle to go
> in but I think we probably want to do this with configure rather than
> ad-hoc ifdefs.
>
> Roger, what do you think ? Were you going to add a configure test for
> the #ifdef that we put in earlier ?
Yes, sorry, I owe you that patch. Will try to do tomorrow so that we
can have a model for other headers. AFAICT I will have to build
something around AC_CHECK_HEADER so that we can get a define that
contains a path that can be used with an #include directive.
Thanks, Roger.
|
