[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.15] tools/configure: add bison as mandatory


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 5 Feb 2021 14:39:53 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lyc7unYAD9k032jv108wYTg80RlGWh+6uMqt7vWKe9s=; b=Ghjhv8HfE8uEbuzqAo84sqCeFkBgJ2pvYS5TtRHbXjppx5G/fQz64lCFQ9aPSGP9OxfWx3vuLjQbQB5ejeM57Tvjx4mdXZaCMEq7pJSUKNgDQXbhFZqtgXfAT1kj0Dqc/UGeYINAhFOlhCBQwe9cRaquYhRiKWm0KLvKRbrsv5HsfccDyquMPWwyrRC850kRmS5Vi3rB3Jn1obkyoZzA+dV9Ik2+DpjFLQx0MsHeVVKyBU8bo1jZe6ijxcVp/vuNEkrRkX1+RS4oYx9B6iIqQCLS8sE3Gak/SCa49GaV7SBoxu1302621+evFdO76u/vW0WRC5gx5f4HJPvFNq2l8A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ISHRWwMcsuCRnf3iJoSFWe/i5U6WYqKA1rZze0CwQ49DErGxUcPoVvgDKUb8LpTtu44GC+MG4mdCSKbwi7iHFBkuy3gY2uNABq5FkV8VYHpOs70oZLlCLMxxB3Lhgp7jJRYT2HBy+PlCOp18TjfCl0qoP0l1NOHRoPGLs65ACD5zVgLZFeyyEX2SGHNL7lzjdy9R2yQgduVhjuGmQ5Grkm2IxDEQ2IW3xzELaGvz4skWGegG4bE2jvc4zd5JTC+/eaabzfJG1yJoU31UfcESyI/CfKzmk2yPnOmqjiHCdStEgciNHRDoinkyB5cAJSJ/5/NwXzo8C1QzNn+f7fvCWA==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 05 Feb 2021 13:40:11 +0000
  • Ironport-sdr: JQ2iRsWx8wYIFxQ80QNV60Q4gqQqHauZMiKbPDK2dDBG/Elw2e4itTYla0hn4ZY6PNG9YtZsup JWntFGQ0mO+a8lk+8VlqlLJa4bxzuPRp+rSOe6uc670beTkOobFv7Xw8wbp/2WmVU/p3RunVEC 7cmqXLToV3LWuTMZ7LIlGNPyNkDWrTuRtCGs20Vmee+o/3WqPZktH7ERMujJvUqFl1n+pENGtv A/a5ocySi9J7xePqrERf5uo8i1nla2ASzMW5bg1gAaZOpDVJEGKnzeQCxsQItqkwQrIFXPOjzB R6o=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Feb 05, 2021 at 01:34:20PM +0000, Andrew Cooper wrote:
> On 05/02/2021 11:53, Roger Pau Monne wrote:
> > Bison is now mandatory when the pvshim build is enabled in order to
> > generate the Kconfig.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Please re-run autogen.sh after applying.
> >
> > Fallout from this patch can lead to broken configure script being
> > generated or bison not detected correctly, but those will be cached
> > quite quickly by the automated testing.
> 
> I think this can be simpler.  Both flex and bison are mandatory libxlutil.

No, we ship the output .c and .h files so that the user only needs to
have bison/flex if it wants to modify the .l or .y files AFAICT?

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.