Re: [PATCH 06/10] stubdom/xenstored: Fix uninitialised variables in lu_read_state()

[Jürgen Groß <jgross@xxxxxxxx>]

On 12.02.21 16:39, Andrew Cooper wrote:
> Various version of gcc, when compiling with -Og, complain:
>
>    xenstored_control.c: In function ‘lu_read_state’:
>    xenstored_control.c:540:11: error: ‘state.size’ is used uninitialized in this
>    function [-Werror=uninitialized]
>      if (state.size == 0)
>          ~~~~~^~~~~
>    xenstored_control.c:543:6: error: ‘state.buf’ may be used uninitialized in
>    this function [-Werror=maybe-uninitialized]
>      pre = state.buf;
>      ~~~~^~~~~~~~~~~
>    xenstored_control.c:550:23: error: ‘state.buf’ may be used uninitialized in
>    this function [-Werror=maybe-uninitialized]
>       (void *)head - state.buf < state.size;
>                      ~~~~~^~~~
>    xenstored_control.c:550:35: error: ‘state.size’ may be used uninitialized in
>    this function [-Werror=maybe-uninitialized]
>       (void *)head - state.buf < state.size;
>                                  ~~~~~^~~~~
>
> Interestingly, this is only in the stubdom build.  I can't identify any
> relevant differences vs the regular tools build.
But me. :-)

lu_get_dump_state() is empty for the stubdom case (this will change when
LU is implemented for stubdom, too). In the daemon case this function is
setting all the fields which are relevant.

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature