[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 for-4.15] tools/libxl: Work around unintialised variable libxl__domain_get_device_model_uid()



Andrew Cooper writes ("[PATCH v2 for-4.15] tools/libxl: Work around 
unintialised variable libxl__domain_get_device_model_uid()"):
> Various version of gcc, when compiling with -Og, complain:
> 
>   libxl_dm.c: In function 'libxl__domain_get_device_model_uid':
>   libxl_dm.c:256:12: error: 'kill_by_uid' may be used uninitialized in this 
> function [-Werror=maybe-uninitialized]
>     256 |         if (kill_by_uid)
>         |            ^
> 
> The logic is very tangled.  Set kill_by_uid on every path.
> 
> No funcational change.
> 
> Requested-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Not-acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>
Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.