[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Stable ABI checking (take 2)
- To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 22 Feb 2021 18:09:13 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHZUAWCWjBNgta8jX/wgNCI+u2JFcJkmEeK4YD5rPPI=; b=ZzRKYQY2Y9mV0ZoYaEyZKYC3YJ1mo2Vx/6U45sRpxH2IHK6F4nt4WaZ9maR001rAgsv8CN63F/soo/13fLNii9E/gw/yze0wfOBZWgPstNCOyeBDaKsnhsN0jxJtXfRW9aU0kjJOeKwO0CjkNXKHwXatAvJ9rTIO2Kqf0keIJTv+cz2B+dxn03VxuaFO6Nqw2mDzfqqLLyG0gYXD1J4FFMfTsS8CTZZWpxGwjQD2he+a0j1RMfA9D7nwoApUNSOGqyryBCVVCBNEgpSEnVFnlP8hfmtS7oWSVJzpZhNVvgc0tY4ItWMzFwb15k5MJPnUCc3qkFdGhR0qXxMSSGnmsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFkYcmfDm4HnsQlTcdc2AG/3W7WO9z4hZBnRunwAIx3eqqBbTyY+P9yj+ilN8pieU31CJJfxH9+iJUJojEXsGLY8NGZMvDaYcu/99mLC3V2vR7A7+HDdbSfUTL+pnTg/xQL1cwjtxjceiR4G9K96mi5u7p5Jicl/wThhHLX847cQVo0UiWaFAKwe/PPcvfDFvxBCUIQJYaqZkpQ3t1nNeFI37hOlYn1Pi9oddrJ4ZxrHPVn9xUJv0M8QB6XMVdHnuz6WSKYFsKBtqqRLHa1CWmxRyyaXW06vHG9AA7ANPitzzCBxA0yVHmfFJMlI/miuLO0i3GgRpveRpn8SRz0H0A==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Feb 2021 18:09:31 +0000
- Ironport-sdr: yDsdRUbJ7KM4I+QvzUp1Gqnn/xx8ICl5qIYivn4mBhHKsh+yuZ2/y4iz+hHUbmQU/cjFIh8eG0 lt/i338d5LtnN63rkIwyDqMyGisGgjdxl74BfvJv2t8pwGiVrlRXlTMkZGEyrK6QNf+wWi98O5 u2gMLDtWxLHZCaQ52G0vfc6VbgmZbbTy1BG6Ds9DOtjrH/mDDKdLITbO7IQaTHfkOwuxLBk/JB Qy0KVAts0K/4Zspwe2Kr4wcPD1wkuqbwUk9FhSb+OJa/HT+mo+v6MI3GLRWxLM0EFmhdg2tFqw dRw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/02/2021 17:21, Ian Jackson wrote:
> Jan Beulich writes ("Re: Stable ABI checking (take 2)"):
>> On 22.02.2021 15:03, Andrew Cooper wrote:
>> +1 for option 2, fwiw.
> I'm in favour of option 2.
Option 2 it is then.
>
> Andrew Cooper writes ("Re: Stable ABI checking (take 2)"):
>> As far as RPM is concerned, splitting the two is important, as %build
>> and %check are explicitly separate steps. I have no idea what the deb
>> policy/organisation is here.
> The reason why distro build systems like to distinguish "build" from
> "check" (run tests) is that often the tests are time-consuming (or
> have intrusive dependencies or other practical problems).
>
> IMO if the ABI check is very fast there is no reason not to run it by
> default. (We have configure to deal with the dependency issue.)
It turns out that libxl causes abi-dumper to churn for ~4s or so, which
isn't ideal. All the other libraries are in the noise.
If we are going for a check-by-default policy, then we obviously need to
exclude the non-stable libraries by default.
However, to fix problems pertaining to the unstable libraries,
downstreams do need to be able to invoke checking on the other libraries
as well.
I'll have a think as to how best to make that happen.
~Andrew
|
