[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/4] x86: Introduce MSR_UNHANDLED


  • To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 23 Feb 2021 19:02:30 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P0/Z9e88+p8B4E8ib4HiG4eVCKTuEgjgJnd6RaqIKfA=; b=UZ1QoB5VfHSjoYXEqHYVr988+C2O8PNUj5Lpur3gTI+Y/O5YXYecDOhb0LADgolVF5X7cubkvcncpo7MWm+7/veLmeOM6QzqKpWA5vM6TczI3XxhqTvyHQh+jHw8uhbZ8NasNqUmukAVLnm62eNhQMCX4xoFi9ugDU/PR0J4U9VxYj7wlYY5HBZLnYgTTiUbNcU1YT4P/97QOLlc4Wm2OHPJ3c6clYcuNW2Hg50RvXnserN0WsVQFVw+6PlJvNGd+yWeeZZ54KtdCgaz8QZVx25Oad6aAMbJRXX16nA1OOtFQHUI7vQBgyG0LYHmogJoF45Ia/iM3G0+E9+q2DnjeQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Diqc2y/9XiiJ4n2zEokzojHCY8Hfm1u3kavDqsE5UjYJwaOHuL5QI6LNgkbd6khizf92HPLfU5AL6TC7WbYE+3pq/RPb/w2M+12i2XZVQfN0ZcN8n3/9ASZu8thB/ONVaompceWEUBzGYnC6hlk5K5ABGaM+8hD1Q100VcVf8ric5cs1vsbDowGLR+3PtA5FnVnUcVCBY356poj4AR35Qv4eM3usebVh27ZHH1QtE5xtoAIpyMTiUnZzVQZgd5qaIrDScouZPe4Pui7l7C23L0+DjIW2j6u5EGPSBIRLsMyR2PoD82w0b3LvO/7jAt7sad0VqDD+QXvyvpCRU0bCqQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, <anthony.perard@xxxxxxxxxx>, <jun.nakajima@xxxxxxxxx>, <kevin.tian@xxxxxxxxx>
  • Delivery-date: Tue, 23 Feb 2021 18:02:47 +0000
  • Ironport-sdr: ghJ0LMW93T0ifyFrWdGQRyUzJ7uhp4XFvy+wIFGUJumOtySwv0PMW6qvzkLp3yxMW18JDWz/EY freL9mkA9aeWXa8zJbuqC1YY8mmp7+86AsMFlDoxUADwHoAMMHAJ1RYp/hc/UakD+6RK0uks8Q bWlNz368a2KuMlEMIp9Hu2Bg7LtvByu35t7OgUBOjXSSjIoWHa4t8YcHPFwYxASItCUAbriiUV hzkYuZdFvNAXM/aW2dTqhdlKLQQroq6W45r7BSPR+zK6WF5NUwN6gn6J4NMRi+tDpZvgwYMzL7 mrw=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Feb 23, 2021 at 11:40:07AM -0500, Boris Ostrovsky wrote:
> 
> On 2/23/21 11:11 AM, Roger Pau Monné wrote:
> > On Tue, Feb 23, 2021 at 10:39:48AM -0500, Boris Ostrovsky wrote:
> >
> >> Before I do that though --- what was the conclusion on verbosity control?
> > Ideally I would like to find a way to have a more generic interface to
> > change verbosity level on a per-guest basis, but I haven't looked at
> > all about how to do that, neither I think it would be acceptable to
> > put that burden on you.
> >
> > Maybe we could introduce another flag to set whether ignored MSRs
> > should be logged, as that would be easier to implement?
> 
> 
> Probably.
> 
> 
>     msr_ignore=["verbose=<bool>", "<range>", "range>", ...]

I think just adding a new option will be easier to parse in xl rather
than placing it in the list of MSR ranges:

msr_ignore=["<range>", "range>", ...]
msr_ignore_verbose=<boolean>

Seems easier to implement IMO.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.