[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page
- To: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Fri, 26 Feb 2021 07:06:45 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MoXytlSl0K1AXeXOek857oZH2IypKcyG+OGvMWS2mww=; b=iFyIuH/g5ghD5Pekqn7NnajakTEdoTE8yxeVso/gD0UgSPdyPutObdEVH3NdTV9ItMZfVyZ3gOQCIbM3w6XOG/xqE7DaY8qr9JNnSUBXwFZnYW3RschUIvo08TSs2LdSfDSzBmw40rqmNC23GHfP/WqeZ0i/LCeGzbhSbdKMrdwUZh1niU8v5A2YsLlBBdji+phSN/SjE+9zkDvCCfYI4bhZz5z4JNzUqw64ZsVLTsscAvVCaC7A2D74UVr5d/1f+zw+aB5gDLHaehvdS0oORhH+Ab7PNI3uBZGyHIVVFG1sG26ldu0o357WS6zd9gP0h6xrSlrmpKP6rG7j/Me6SQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHErMpdkELMUUAO39HMOjWjIa1P9Kc4j44x4Hdj5+Fi3bTRmb11aswvJW7+Iil3suqrfrESVYeJG6hME0qMgCb3XqYoK3nI7aNkdwk2JCT1KiVtE2F3kLeuFqhT8AxUYItUk9LpT+jO7l7pFjAL8405i8X/QXTDlW1qbV0zccFkTeiMxCohPjb8duBHltl+FlbtTQ6tfFmYTzGklRE3WDbypXcN0JVoxsXuPA2kC9aTkkrDZ8CZERhmFC23BcVdsaw4EzZeg2OWPJ6SRhaZ4BYlVQnm+g2Dzk5dp1tAvWTuUpRVBttLZ/zFNzkRKsX6oWH/Wbn0sHmQM07LO3EEfdw==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
- Cc: Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 26 Feb 2021 07:06:56 +0000
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.5.1.3
- Ironport-sdr: rAAaw3KLm8Wi1H9bgSYeYFGMrCKvCi893UQdW9ptVStxSHAaZku95s1+zgCW+2kN8uBtAHQXex X+gTSuIge49Q==
- Ironport-sdr: 81yUy2mej71ymMlOwA/ufYfSwQUlAFaD+v3nn0Q7R+LFJK/OMvjdgiZownspi0f1yLVsmVPjS8 7mPrPya04acw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXCQl5Ge7Qk928g0a5oin2oF6ik6poksSAgAF27OA=
- Thread-topic: [PATCH v3 1/2][4.15] VMX: delay p2m insertion of APIC access page
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, February 25, 2021 4:44 PM
>
> On 22.02.2021 11:56, Jan Beulich wrote:
> > --- a/xen/arch/x86/hvm/vmx/vmx.c
> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
> > @@ -428,6 +428,14 @@ static void vmx_domain_relinquish_resour
> > vmx_free_vlapic_mapping(d);
> > }
> >
> > +static void domain_creation_finished(struct domain *d)
> > +{
> > + if ( has_vlapic(d) && !mfn_eq(d->arch.hvm.vmx.apic_access_mfn,
> _mfn(0)) &&
> > + set_mmio_p2m_entry(d, gaddr_to_gfn(APIC_DEFAULT_PHYS_BASE),
> > + d->arch.hvm.vmx.apic_access_mfn,
> > PAGE_ORDER_4K) )
> > + domain_crash(d);
> > +}
>
> Having noticed that in patch 2 I also need to arrange for
> ept_get_entry_emt() to continue to return WB for this page, I'm
> inclined to add a respective assertion here. Would anyone object
> to me doing so?
>
> Kevin, Jun - I'd like this to also serve as a ping for an ack
> (with or without the suggested ASSERT() addition).
>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
|
