[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] VMX: use a single, global APIC access page
- To: Jan Beulich <jbeulich@xxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Mon, 1 Mar 2021 02:08:48 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SM6fWWQYALeaONjtsblI/MM+unLUBrW10cVDx5gLMoM=; b=G60hVbfgkMhk5a5ZaVLs9t1L+B4cMO3oLdNUmwp+ERlGJ98NCBjTfrA5g3oDmw02uu3UhGnUQ5DRYPszolEgrDQZCLU02gDBdSv3Zmz5s1VeJQmAiaxFZwlkNqEQVzDmTbtWcqCEQ3FW2aZIlS0bjnJm4F2Taaxi/JdSJ63K7SmfSeRnTT8BjxuC/ZhQp6Y97glOhaEqgIjgMnJSZu33lECN3qmkJayb20kIUSKyE7L6+jmciw4fkWWM+48iADmrzd/6P1gTrlRsEOXUymFt36Lx7bpEhFbHtW8g/GwYMSMF14y8/IZYrMU/FOzuz0uDlH+CHjUCvvuy8Y3F/vSxsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lFdwTK38ywkuOJHoiv+ykYs2Sojq71nAD96WWCydlnMX9rylWje1aH1AYYhQcjwqOJvdRYzrSmPSX/w/nmdHj5QTYwGuGMazf3nU8S4JjgG7poJeSUXR/01BEQenIXuavlTEWlrOiqjnL81shz6upFj6b37Xp4HmAo/AiuqAJJEmi3O1B21MHqzd4Hx1M6S0GZPq/OwovYDV7NCp/U9pDwWdH9/EHmAJe2WRF3r4Xzjht0MQvpTDlrN9JA04R3WnHzWl4zdyZ1wEb5SEdxHKeP9wLMQ552wrLafpL7XXFBEZ7+4SMHHE15J5kGuuGThuKl7+6QzrD8EvNyREW6HBsA==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
- Cc: Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 01 Mar 2021 02:12:58 +0000
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.5.1.3
- Ironport-sdr: KF4fSGHsjIZw2VW2jNx/Wvi/w8rz3iAAxL9mM0dvIpTNdIoq8nTweaNJmz9p3IpivpHqOLU7a1 NisTRZVP6KdQ==
- Ironport-sdr: xXo7xspist5dqf5Csg5euK3q349+HgTTe/1TtahnOfd2nNu+08IxQq51oNkfn5LubYtCqd+eQK +HHCkF/Dz4lw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHW/8yZa97+qDgbIE6iwG3wuPN9papRnNEAgAABAgCAHOIDYA==
- Thread-topic: [PATCH] VMX: use a single, global APIC access page
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, February 11, 2021 1:04 AM
>
> On 10.02.2021 18:00, Andrew Cooper wrote:
> > On 10/02/2021 16:48, Jan Beulich wrote:
> >> The address of this page is used by the CPU only to recognize when to
> >> instead access the virtual APIC page instead. No accesses would ever go
> >> to this page. It only needs to be present in the (CPU) page tables so
> >> that address translation will produce its address as result for
> >> respective accesses.
> >>
> >> By making this page global, we also eliminate the need to refcount it,
> >> or to assign it to any domain in the first place.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > How certain are you about this?
>
> The documentation (I'm inclined to say: unexpectedly) is very
> clear about this; I don't think it had been this clear back at
> the time. I'm hoping for Kevin to shout if he's aware of issues
> here.
>
No, I didn't see an issue here.
Thanks
Kevin
|