[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.15] automation/alpine: add g++ to the list of build depends
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 1 Mar 2021 18:01:36 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tg09GtKNi5LILMUgCDejGPKjpl4a1uVUaqPshwqYcek=; b=OYP5BHtewHpnbLWgLCrq6iCeLOXaBYdNP2VdD2TN0NYh1J1Cc9ClCHQhSIR0Wt9ZpjhmD7NpM4fFBYpkzlRVyNLWAW+dmN8L177CiywtuVYVmwDoNndKTRgPby+AnEXWR0xN8sXgV+TeEXmu9/6LXweVu1Q2xsUn+3JaiWafi6EFQwqlrchMJSMnQftcNknDtvslXIJ5tDcMM+ognH8DeqqArAc1xz/GEwg3xFJY6OEkiXX48FEcYDGBrIXVZOMV8b4pEijLc1WHdm1vewFHbT5K6h9uMRUMUoMEqxnp3tKPiz8zYGZzFHw9J33VBGJ7d6wiOWgAmTI00OSZf5rw6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PwZ3taDABVuR5k4xRQKZIgxXGGJFUuA9UpshhCprbeHUxyU8/l5l6sD9TLqeCmWGfF2d362yPd5JfK/mzIuuziXUw+kMRTwWe8PQYH01Zb9Z0V+n9vBd/vXgWIoe1iv5XRll+QiaQp9AY76tkmnFhoHUWMIiTKOUXLb0UQFvP15gcaW1Mfyivl/umQfq3pR2hqdKyH1nkJ5U9zpoaVo9HFAswAWVkO/hwBuoCuC6CzV4lUtjJR5lffd/Afme0HUbRa3oiRzgwXtwBCm+ZqgORukVNa6ib5gBbx4NSVsqSDfhotTGWUTgktjExTP8X5uQ52j041F5+FchnI9YGth68A==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Mon, 01 Mar 2021 18:01:51 +0000
- Ironport-sdr: 5kID+Bg7W6SJhrtta6/MtVYkivadpNyPChXuTN9Xq4zyKd8JIY5gQDLbyVl6MSt8xDeqc7woUU g4uxriYXHp/NhrG9i+Xt6+ahUi+2Xy21XtAUm/2+o2fhLyoc0P/kFMxpB/FKz0LNWRNnHL+Dth i4Cxsy//ROC/m+ADj9GuwEnsCpyZNOdKzVBPEP0Ab4+OlXViyONFMOVyBIO5csRCB3PFsWWkfe 537Q7vS7EUIO+N7Bt4Y5DAhslkkpQQtMBdw1ykqPfqjBvYP5zJVLhhgJ2F0Deq2yWx/NeXCZee 2Rw=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/03/2021 17:59, Andrew Cooper wrote:
> On 01/03/2021 09:58, Roger Pau Monne wrote:
>> clang++ relies on the C++ headers installed by g++, or else a clang
>> build will hit the following error:
>>
>> <built-in>:3:10: fatal error: 'cstring' file not found
>> #include "cstring"
>> ^~~~~~~~~
>> 1 error generated.
>> make[10]: *** [Makefile:120: headers++.chk] Error 1
>>
>> Reported-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> ---
>> Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>
>> No real risk here from a release PoV, it's just pulling a package
>> required for the Alpine clang build. Worse that cold happen is that
>> the Alpine clang build broke, but it's already broken.
> Shouldn't this be fixed upstream in Alpine? Its clearly a packaging bug.
Or (thinking about it), we've got a build system bug using g++ when it
should be using clang++.
How does this check work (without g++) on a non-clang build?
~Andrew
|
