[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction
Julien Grall writes ("[PATCH for-4.15] tools/xenstored: liveupdate: Properly check long transaction"): > From: Julien Grall <jgrall@xxxxxxxxxx> > > As XenStored is single-threaded, conn->ta_start_time will always be > smaller than now. As we substract the latter from the former, it means > a transaction will never be considered long running. > > Invert the two operands of the substraction in both lu_reject_reason() > and lu_check_allowed(). In addition to that, the former also needs to > check that conn->ta_start_time is not 0 (i.e the transaction is not > active). > > Take the opportunity to document the return condition of > lu_check_allowed(). AFAICT this only affects live updated which is not security-supported in 4.15 and which won't block our tests. So: Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx> Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |