[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error
Norbert Manthey writes ("Re: [PATCH XENSTORE v1 09/10] xs: handle daemon socket error"): > On 3/3/21 5:13 PM, Ian Jackson wrote: > > Norbert Manthey writes ("[PATCH XENSTORE v1 09/10] xs: handle daemon socket > > error"): > >> When starting the daemon, we might see a NULL pointer instead of the > >> path to the socket. .. > > ... this is client code ? > > This is client code, yes. The patched 'get_handle' function receives the > parameter 'connect_to' in the function xs_open. There, the value of the > functions 'xs_deamon_socket_ro', 'xs_deamon_socket' and 'xs_domain_dev' > are passed to this function, without checking for the value NULL. > > I agree that the description might be confusing, as the fix is applied > to a function that does not cause the actual problem. How about > rephrasing the first part of the commit message to the above proposal? Improving the commit message seems to me to be needed in any case since as far as I can tell from what I read here, the existing one is actualy wrong :-). With my maintainer/reviewer hat on, I think this new exit path involves returning an error from this function without setting errno, so it's wrong ? As for the release, I think this is a very low-impact bug and now it seems not 100% obvious, so unless someone would like to explain why it should go into 4.15 I'd like to see it in -next. Thanks, Ian.
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |