[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/dmop: Strip __XEN_TOOLS__ header guard from public API
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 5 Mar 2021 14:12:51 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=db6kB8vegPIS52yAWhLRx1GVwoRd6y5faVL6HOqWIH8=; b=m7sqExvWx8d+5eJ9Tqc2DR3ECusgSvpOvnDgC2tviB68E9Q8ubfuav8xNYo64W694riU1DDILWqmAJx5w+fZMKdAcoAd2qTmTP/nBEicB3sdNzykRDL0KFqLsv6Wxj7HuL4LCRW4MGmj+thVHkQDtemTHMTGyoRF86JmZmJ60VSK3Iqf/+6Mnd5wbM5TjP5YmARr78KFRtpe0t8G+UEHsEsARaA1em1C6S1YPP0Bjrav/iaPLfv2Qwa3YWHU3S638E4VN4UnonP4ZxbJ/fOZ6oVzZY07XW4BSI+SQPkHMdbKQGHIAcJ2ZAC30Hxm/22nJ6QNLS9IKeNcYelV74+lcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kpMBc+AGYHC6fwqQ6lJd9NVHdM8O5a5qNKdpOPEJwaOK5xjmYVWohl+uwPGVtTEQhy44xBrezNk90sItA2oOGpUsCn+5gSm4HrALpHf6NAPnw+t4fgtELeg3ulHLcVrQRUcOpZHewgKgQT4ooJND355ftMPasxc68yy1DtwbMZeQ0UuaxEnDiv/K9AxUXzKcFXjtgxvr+BMOyVvg1pzo3DRaj4s5qTCeOB+gJpKA0/dS5fT1rFRbVSrEN6fA/4k9eJ/RsneajO/HGXgP1IJxXUjpVacelmClABGXykv+jbod+Qhg/AH7OQ+wWfCsmOsgkpZo1f0p+guv2LGe8JP3aQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 05 Mar 2021 14:13:14 +0000
- Ironport-sdr: WvWV7ACoavcuhoL/Ftfuevooblrkv2p8d6+rVpS92f0ZSdDok5VkNpZTmBcvt1wzrdBXpdwHyz qkmnvqzBgtdqNYyNvrhCbz00BwPJ0LsJS+k7Ug1LO6vCbFbNEZAHCnJkBs83pkxL1mG8UnQkV5 tQM+RJBVUgRsy9vRpFdIyjmnOcA28V08UyJXUy1yGj9ZaZnomfMijDI9Efh32vgwuS7hz1HLIZ Y7v5SyhCJHTG5ebTnd+C2bx6pjZ+jBqDXUpy5BrdtCwg55rSGDuNvY8+BDKlONkKfnu0447WGz 66s=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/03/2021 13:53, Jan Beulich wrote:
> On 05.03.2021 13:49, Andrew Cooper wrote:
>> Exactly as with c/s f40e1c52e4, this is inappropriate for a stable library.
>>
>> That change actually broke the build with:
>>
>> include/xendevicemodel.h:52:5: error: unknown type name 'ioservid_t'
>> ioservid_t *id);
>> ^
>>
>> as libxendevicemodel.h now uses a type it can't see a typedef for. However,
>> nothing noticed because the header.chk logic is also broken (fixed
>> subsequently).
> While I agree up to here, ...
>
>> Strip the guard from the public header, and remove compensation from
>> devicemodel's private.h
> ... I'm unconvinced that entirely dropping the guard from the
> public header is wanted (or needed): We use these to make clear
> that in particular kernels aren't supposed to make use of the
> enclosed entities. If a type needs exposing, it (and only it)
> wants moving ou of the guarded region imo.
DMOP was invented specifically so a kernel module (i915, for Intel
gVT-g) was independent of the domctl ABI version.
Improving the life of dom0 userspace was an intended consequence, but
not the driving force behind the change.
Exactly the same is true for stubdoms currently, and I am very serious
about purging unstable interfaces eventually.
~Andrew
|
