Re: [PATCH] arm: Add Kconfig entry to select CONFIG_DTB_FILE

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Jan,

On 08.03.2021 11:00, Jan Beulich wrote:
> On 08.03.2021 10:52, Michal Orzel wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -400,6 +400,20 @@ config DOM0_MEM
>>  
>>        Leave empty if you are not sure what to specify.
>>  
>> +config LINK_DTB
>> +    bool "Link DTB into Xen image"
>> +    depends on ARM
>> +    default n
> 
> I don't think this last line is needed.
> 
I agree. I can fix it.
>> +config DTB_FILE
>> +    string "Absolute path to device tree blob"
>> +    default ""
>> +    depends on LINK_DTB
>> +    ---help---
>> +      When using a bootloader that has no device tree support or when there
>> +      is no bootloader at all, use this option to specify the absolute path
>> +      to a device tree that will be linked directly inside Xen binary.
> 
> How is selecting LINK_DTB but leaving DTB_FILE at an empty string
> different from not having a LINK_DTB setting at all?
> 
LINK_DTB acts as a switch to allow setting the dtb path. Not having LINK_DTB 
option will result in
a build failure each time the user does not want to embed dtb into Xen(DTB_FILE 
is empty).
I do not see why someone would want to select LINK_DTB leaving DTB_FILE as an 
empty string.
> Jan
> 

Cheers,
Michal