[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild cpuid-autogen.h every time



On 08.03.2021 13:12, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 1/2][4.15?] tools/x86: don't rebuild 
> cpuid-autogen.h every time"):
>> Possibly, but it may end up being more complex: We want to only
>> retain files of specific names from a single dir. I don't think
>> this is as straightforward to express in a find rune. Of course
>> I'll be fine whichever way the bug gets fixed, but I'm afraid I
>> don't feel convinced I want to put time into trying the alternative
>> you suggest. If otoh you wanted to try out yours and it turned out
>> equivalent or better, I wouldn't mind at all.
> 
> Untested, but I think something like this should DTRT
> 
>  find xen ! -type d ! -path 'xen/lib/x86/*-autogen.h' -print0 | xargs -0r rm 
> --
> 
> Since my background is GNU utilities, I checked the FreeBSD manpages
> for find, xargs and rm.  They support these options.
> 
> This will leave the entire directory structure but I think that is
> fine.  The xen-dir target uses mkdir -p and should there be any stale
> directories (eg due to switching branches or whatever) they wouldn't
> be a problem.

Right. Thinking of it though - all we do is setting up symlinks
plus produce this generated header. Couldn't we therefore have
find simply arrange for all symlinks to be found and deleted?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.